Age | Commit message (Collapse) | Author | |
---|---|---|---|
2023-06-08 | Use pages root directory from API | Janis Altherr | |
2023-05-08 | Upgrade golangci-lint to v1.52.2 on CI | Jaime Martinez | |
2023-04-12 | Update golangci-lint tool | Kassio Borges | |
2023-02-14 | Revert back to archive/zip | Kassio Borges | |
2022-07-25 | Merge branch 'sh-log-zfs-corruption-error' into 'master' | Stan Hu | |
chore: log ZIP archive corruption error See merge request gitlab-org/gitlab-pages!821 | |||
2022-07-23 | Chore: log ZIP archive corruption errorsh-log-zfs-corruption-error | Stan Hu | |
When a ZIP file cannot be opened for some reason, we previously would discard the error after attempting to retrieve it from the cache. While this error is logged in another message, it would be helpful to have the same message tied with the "archive corrupted" log entry. Relates to https://gitlab.com/gitlab-org/gitlab-pages/-/issues/690 Changelog: changed | |||
2022-07-15 | Revert: open files lazily when serving content | Vladimir Shushlin | |
This reverts merge request https://gitlab.com/gitlab-org/gitlab-pages/-/merge_requests/803 because it caused an incident when serving large compressed files Changelog: fixed | |||
2022-07-07 | Open files lazily when serving content | feistel | |
Changelog: performance | |||
2022-07-04 | Null out file slice | feistel | |
2022-07-04 | Convert archive field to a local variable | feistel | |
2022-07-04 | Null out zip reader after reading archive | feistel | |
2022-06-28 | Improve consistency of log fields | feistel | |
2022-06-21 | Merge branch 'jv-clear-timezone' into 'master' | Vladimir Shushlin | |
Clear timezones from cached zip entries See merge request gitlab-org/gitlab-pages!791 | |||
2022-06-21 | Clear timezones from cached zip entries | Jacob Vosmaer | |
In https://gitlab.com/gitlab-org/gitlab-pages/-/issues/702 we discovered that by caching many `*zip.File` instances, we end up storing many Go timezone objects on the heap: one per cached `*zip.File`. This adds up to about 25% of the heap size. In this commit we set the timestamp of `*zip.File` to UTC. Because Go re-uses a single timezone object for UTC, this causes the original timezone objects of the `*zip.File` instances to be garbage collected. This reduces the heap size. Here is an example program that demonstrates the effect: ```golang package main import ( "archive/zip" "log" "os" "runtime/pprof" ) func main() { if err := load(os.Args[1]); err != nil { log.Fatal(err) } log.Printf("load finished: %d archives", len(readers)) pprof.WriteHeapProfile(os.Stdout) } var readers []*zip.ReadCloser func load(filename string) error { for i := 0; i < 1000; i++ { zr, err := zip.OpenReader(filename) if err != nil { return err } if os.Getenv("FORCE_UTC") == "1" { for _, zf := range zr.File { zf.Modified = zf.Modified.UTC() } } readers = append(readers, zr) } return nil } ``` | |||
2022-06-17 | Properly handle io.copy errors | feistel | |
Changelog: added | |||
2022-05-16 | Add logs for more visibility in 404s and archive corruption event | Vishal Tak | |
2022-03-14 | add flag to parameterize zip http client timeout | vtak | |
Changelog: added | |||
2022-03-11 | Add correlation_id to all exception captures | Kassio Borges | |
2022-02-03 | test: migrate to assertions using modern error checking | feistel | |
2022-02-02 | lint: fix linter issues | feistel | |
2022-02-01 | fix: Fix 500 errors when clients disconnect | Vladimir Shushlin | |
When clients disconnect, we now logging 500 error due to Context.Cancelled error. This leads to alerts and uses up our error budgets. This reverts merge request !676 Changelog: fixed | |||
2022-01-31 | chore: return early for head requests | Jaime Martinez | |
2022-01-29 | fix: catch io.copy errors when serving content | feistel | |
2022-01-26 | Merge branch 'feat/errorlint' into 'master' | Jaime Martinez | |
build: enable errorlint and use modern error checking See merge request gitlab-org/gitlab-pages!648 | |||
2022-01-24 | test: replace tmpdir workaround with native T tmp | feistel | |
2022-01-24 | lint: fix errorlint issues | feistel | |
2022-01-24 | lint: fix gci issues | feistel | |
2022-01-20 | lint: solve internal/vfs/serving linter issues | feistel | |
2021-12-16 | fix: update vfs/zip implementation to ensure minimum range requests for go1.17 | Arran Walker | |
Using `gitlab.com/gitlab-org/golang-archive-zip` instead of the `archive/zip` package from the stdlib. Changelog: changed | |||
2021-12-14 | Merge branch 'fix/sha-lookups' into 'master' | Jaime Martinez | |
test: add sha256 to mocked lookups and fix tests See merge request gitlab-org/gitlab-pages!634 | |||
2021-12-14 | refactor: promote missingcachekey error to a static error | feistel | |
2021-12-13 | fix: return an error if the cacheKey is empty | feistel | |
2021-12-08 | Merge branch 'remove-unused-ctx' into 'master' | Jaime Martinez | |
refactor: enable unparam in .gitlabci.yml See merge request gitlab-org/gitlab-pages!631 | |||
2021-12-08 | test: add sha256 to mocked lookups and fix tests | feistel | |
2021-12-07 | Merge branch 'upgrade-labkit-1-11-0' into 'master' | Vladimir Shushlin | |
chore: upgrade to labkit 1.11.0 See merge request gitlab-org/gitlab-pages!633 | |||
2021-12-07 | refactor: enable unparam in .golangci.yml | Vladimir Shushlin | |
and fix offences | |||
2021-12-07 | chore: upgrade to labkit 1.11.0 | Jaime Martinez | |
And report stack trace with error tracking to Sentry. Changelog: other | |||
2021-12-06 | refactor: move keyFromPath our of zipVfs object | Vladimir Shushlin | |
2021-12-01 | Merge branch 'refactor/limiter-new' into 'master' | Jaime Martinez | |
refactor: make internal/lru and internal/ratelimiter metrics optional Closes #647 See merge request gitlab-org/gitlab-pages!606 | |||
2021-12-01 | chore: update method names | feistel | |
2021-11-25 | refactor: add functional option to customize lru cache size and expiration | feistel | |
don't expose default values and keep them private. | |||
2021-11-17 | Merge branch 'fix/native-fs-error' into 'master' | Jaime Martinez | |
refactor: remove vfs.ErrNotExist and switch to go native fs error See merge request gitlab-org/gitlab-pages!569 | |||
2021-11-16 | refactor: move away from error '==' comparison | Jaime Martinez | |
2021-11-16 | feat: handle extra headers when serving from compressed zip archive | feistel | |
Related to https://gitlab.com/gitlab-org/gitlab-pages/-/issues/466 Changelog: added | |||
2021-11-15 | refactor: provide more context for symlink errors | Brian Williams | |
2021-11-11 | refactor: remove vfs.ErrNotExist and switch to go native fs error | feistel | |
2021-11-08 | style: revert explicit params type | Jaime Martinez | |
2021-11-08 | refactor: read and use file_sha256 as cache key for zip VFS | feistel | |
Now that the Rails API is serving the archive file_sha256 in the lookup response, we can move away from using the base URL as the key to cache the archive. Changelog: change | |||
2021-11-01 | refactor: make internal/lru and internal/ratelimiter metrics optional | feistel | |
2021-10-01 | Merge branch 'remove/chrootpath' into 'master' | Alessio Caiazza | |
refactor: clean up chrootPath from the httpfs package Closes #598 See merge request gitlab-org/gitlab-pages!559 |