Age | Commit message (Collapse) | Author | |
---|---|---|---|
2022-02-17 | revert: revert all the changes on *_test.go files. | yigithankardas | |
2022-02-16 | refactor: simplify parsing and remove whitespace handling | feistel | |
2022-02-16 | test: make sure the expected headers are using canonical keys | feistel | |
2022-02-16 | test: fix failing tests | feistel | |
When passing invalid header keys (if it contains spaces or non-token bytes), the key is unchanged and a string copy is returned. Since tests expect trailing whitespaces in the header key to be stripped we need to do it manually instead of relying on CanonicalMIMEHeaderKey | |||
2022-02-16 | refactor: parse custom headers using ReadMIMEHeader | feistel | |
2022-02-16 | reset: go back to initial commit. | yigithankardas | |
2022-02-10 | fix: do no retry resolving the domain if there's a ctx error | feistel | |
during a ctx error the retriever was leaking the goroutine leading to the same error on each try and keeping around the goroutine more than retrieverTimeout. Changelog: fixed | |||
2022-02-04 | Merge branch 'test/move-mocks' into 'master' | Vladimir Shushlin | |
test: move mocks to their own package See merge request gitlab-org/gitlab-pages!671 | |||
2022-02-03 | test: migrate to assertions using modern error checking | feistel | |
2022-02-03 | Merge branch 'sh-normalize-status-code-logging' into 'master' | Jaime Martinez | |
fix: ensure logging status codes field names are consistent See merge request gitlab-org/gitlab-pages!679 | |||
2022-02-02 | lint: fix linter issues | feistel | |
2022-02-01 | fix: Fix 500 errors when clients disconnect | Vladimir Shushlin | |
When clients disconnect, we now logging 500 error due to Context.Cancelled error. This leads to alerts and uses up our error budgets. This reverts merge request !676 Changelog: fixed | |||
2022-02-01 | Merge branch 'remove/file-descriptors' into 'master' | Jaime Martinez | |
refactor: stop passing file descriptors around and use net.Listen directly See merge request gitlab-org/gitlab-pages!667 | |||
2022-02-01 | Merge branch 'add-custom-logger-fields' into 'master' | Jaime Martinez | |
fix: fix metrics and logs not including domain resolution time See merge request gitlab-org/gitlab-pages!674 | |||
2022-02-01 | lint: reduce cyclomatic complexity of validateListeners func | feistel | |
2022-02-01 | refactor: forbid empty listeners | feistel | |
2022-02-01 | docs: clarify ListenHTTPStrings are being used directly now | feistel | |
2022-02-01 | refactor: stop passing file descriptors around and use net.Listen | feistel | |
Changelog: changed | |||
2022-01-31 | fix: ensure logging status codes field names are consistent | Stan Hu | |
LabKit logs all HTTP responses with a `status` field of an integer. We ensure that all errors now use this convention and store the full status text as `status_text`. This is needed to enusre Elasticsearch doesn't drop logs due to mapping conflicts. Changelog: fixed | |||
2022-01-31 | fix: fix metrics and logs not including domain resolution time | Vladimir Shushlin | |
Currently we do logging and metrics capturing after we did the domain information lookup. It allows us to add more information to access logs. But it also distorts metrics because domain information lookup takes time. This logic was originally introduced in https://gitlab.com/gitlab-org/gitlab-pages/-/merge_requests/157/diffs It didn't matter back than because we didn't lookup domain via API as we do now. Now it does matter. So this commits moves metrics and logging middlewares almost to the top of pipeline. Changelog: fixed | |||
2022-01-31 | Merge branch 'refactor/config-err-private' into 'master' | Jaime Martinez | |
refactor: make config validation errors private Closes #664 See merge request gitlab-org/gitlab-pages!644 | |||
2022-01-31 | Merge branch 'fix/catch-serve-errors' into 'master' | Jaime Martinez | |
fix: catch io.copy errors when serving content See merge request gitlab-org/gitlab-pages!676 | |||
2022-01-31 | chore: return early for head requests | Jaime Martinez | |
2022-01-30 | fix: log errors when HTTP range requests fail | Stan Hu | |
When a HTTP range fails, we see changes in Prometheus metrics but it would be helpful to know exactly why certain requests fail. Relates to https://gitlab.com/gitlab-org/gitlab-pages/-/issues/690 Changelog: fixed | |||
2022-01-29 | fix: catch io.copy errors when serving content | feistel | |
2022-01-26 | test: move mocks to their own package | feistel | |
2022-01-26 | Merge branch 'mock/resolver' into 'master' | Alessio Caiazza | |
test: update domain test to use mocked resolver See merge request gitlab-org/gitlab-pages!647 | |||
2022-01-26 | Merge branch 'feat/errorlint' into 'master' | Jaime Martinez | |
build: enable errorlint and use modern error checking See merge request gitlab-org/gitlab-pages!648 | |||
2022-01-26 | Merge branch 'test/valid-tls' into 'master' | Jaime Martinez | |
test: add valid tls config tests See merge request gitlab-org/gitlab-pages!581 | |||
2022-01-25 | Merge branch 'refactor/test-tmp' into 'master' | Vladimir Shushlin | |
test: replace tmpdir workaround with native T tmp See merge request gitlab-org/gitlab-pages!598 | |||
2022-01-25 | Merge branch 'test/acme-malformed' into 'master' | Vladimir Shushlin | |
test: add malformed acme middleware url test See merge request gitlab-org/gitlab-pages!580 | |||
2022-01-24 | test: replace tmpdir workaround with native T tmp | feistel | |
2022-01-24 | test: add valid tls config tests | feistel | |
2022-01-24 | lint: fix errorlint issues | feistel | |
2022-01-24 | test: expand request package tests and migrate to table-driven tests | feistel | |
2022-01-24 | test: update domain test to use mocked resolver | feistel | |
2022-01-24 | test: add malformed acme middleware url test | feistel | |
2022-01-24 | test: add mocked resolver | feistel | |
2022-01-24 | Merge branch 'feat/gci' into 'master' | Jaime Martinez | |
build: add gci linter Closes #671 See merge request gitlab-org/gitlab-pages!643 | |||
2022-01-24 | Merge branch 'require/http-status' into 'master' | Jaime Martinez | |
test: replace http status assertions with testify method See merge request gitlab-org/gitlab-pages!637 | |||
2022-01-24 | lint: fix gci issues | feistel | |
2022-01-24 | Merge branch 'ci/exclude-rules' into 'master' | Jaime Martinez | |
ci: only skip golangci for internal/mocks See merge request gitlab-org/gitlab-pages!661 | |||
2022-01-24 | test: regenerate client mock | feistel | |
2022-01-24 | test: update tests to new client stub | feistel | |
the old client_stub is removed and tests have been updated to table tests | |||
2022-01-24 | refactor: migrate client stub to mockgen | feistel | |
2022-01-20 | fix: fix error message for disabled placeholders | Vladimir Shushlin | |
2022-01-20 | lint: solve internal/vfs/serving linter issues | feistel | |
2022-01-20 | lint: solve internal/serving/disk/symlink linter issues | feistel | |
2022-01-19 | refactor: remove internal/httputil package | feistel | |
2022-01-19 | feat: switch to content negotiation library | feistel | |
Changelog: changed |