Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-pages.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-02-17revert: revert all the changes on *_test.go files.yigithankardas
2022-02-16refactor: simplify parsing and remove whitespace handlingfeistel
2022-02-16test: make sure the expected headers are using canonical keysfeistel
2022-02-16test: fix failing testsfeistel
When passing invalid header keys (if it contains spaces or non-token bytes), the key is unchanged and a string copy is returned. Since tests expect trailing whitespaces in the header key to be stripped we need to do it manually instead of relying on CanonicalMIMEHeaderKey
2022-02-16refactor: parse custom headers using ReadMIMEHeaderfeistel
2022-02-16reset: go back to initial commit.yigithankardas
2022-02-10fix: do no retry resolving the domain if there's a ctx errorfeistel
during a ctx error the retriever was leaking the goroutine leading to the same error on each try and keeping around the goroutine more than retrieverTimeout. Changelog: fixed
2022-02-04Merge branch 'test/move-mocks' into 'master'Vladimir Shushlin
test: move mocks to their own package See merge request gitlab-org/gitlab-pages!671
2022-02-03test: migrate to assertions using modern error checkingfeistel
2022-02-03Merge branch 'sh-normalize-status-code-logging' into 'master'Jaime Martinez
fix: ensure logging status codes field names are consistent See merge request gitlab-org/gitlab-pages!679
2022-02-02lint: fix linter issuesfeistel
2022-02-01fix: Fix 500 errors when clients disconnectVladimir Shushlin
When clients disconnect, we now logging 500 error due to Context.Cancelled error. This leads to alerts and uses up our error budgets. This reverts merge request !676 Changelog: fixed
2022-02-01Merge branch 'remove/file-descriptors' into 'master'Jaime Martinez
refactor: stop passing file descriptors around and use net.Listen directly See merge request gitlab-org/gitlab-pages!667
2022-02-01Merge branch 'add-custom-logger-fields' into 'master'Jaime Martinez
fix: fix metrics and logs not including domain resolution time See merge request gitlab-org/gitlab-pages!674
2022-02-01lint: reduce cyclomatic complexity of validateListeners funcfeistel
2022-02-01refactor: forbid empty listenersfeistel
2022-02-01docs: clarify ListenHTTPStrings are being used directly nowfeistel
2022-02-01refactor: stop passing file descriptors around and use net.Listenfeistel
Changelog: changed
2022-01-31fix: ensure logging status codes field names are consistentStan Hu
LabKit logs all HTTP responses with a `status` field of an integer. We ensure that all errors now use this convention and store the full status text as `status_text`. This is needed to enusre Elasticsearch doesn't drop logs due to mapping conflicts. Changelog: fixed
2022-01-31fix: fix metrics and logs not including domain resolution timeVladimir Shushlin
Currently we do logging and metrics capturing after we did the domain information lookup. It allows us to add more information to access logs. But it also distorts metrics because domain information lookup takes time. This logic was originally introduced in https://gitlab.com/gitlab-org/gitlab-pages/-/merge_requests/157/diffs It didn't matter back than because we didn't lookup domain via API as we do now. Now it does matter. So this commits moves metrics and logging middlewares almost to the top of pipeline. Changelog: fixed
2022-01-31Merge branch 'refactor/config-err-private' into 'master'Jaime Martinez
refactor: make config validation errors private Closes #664 See merge request gitlab-org/gitlab-pages!644
2022-01-31Merge branch 'fix/catch-serve-errors' into 'master'Jaime Martinez
fix: catch io.copy errors when serving content See merge request gitlab-org/gitlab-pages!676
2022-01-31chore: return early for head requestsJaime Martinez
2022-01-30fix: log errors when HTTP range requests failStan Hu
When a HTTP range fails, we see changes in Prometheus metrics but it would be helpful to know exactly why certain requests fail. Relates to https://gitlab.com/gitlab-org/gitlab-pages/-/issues/690 Changelog: fixed
2022-01-29fix: catch io.copy errors when serving contentfeistel
2022-01-26test: move mocks to their own packagefeistel
2022-01-26Merge branch 'mock/resolver' into 'master'Alessio Caiazza
test: update domain test to use mocked resolver See merge request gitlab-org/gitlab-pages!647
2022-01-26Merge branch 'feat/errorlint' into 'master'Jaime Martinez
build: enable errorlint and use modern error checking See merge request gitlab-org/gitlab-pages!648
2022-01-26Merge branch 'test/valid-tls' into 'master'Jaime Martinez
test: add valid tls config tests See merge request gitlab-org/gitlab-pages!581
2022-01-25Merge branch 'refactor/test-tmp' into 'master'Vladimir Shushlin
test: replace tmpdir workaround with native T tmp See merge request gitlab-org/gitlab-pages!598
2022-01-25Merge branch 'test/acme-malformed' into 'master'Vladimir Shushlin
test: add malformed acme middleware url test See merge request gitlab-org/gitlab-pages!580
2022-01-24test: replace tmpdir workaround with native T tmpfeistel
2022-01-24test: add valid tls config testsfeistel
2022-01-24lint: fix errorlint issuesfeistel
2022-01-24test: expand request package tests and migrate to table-driven testsfeistel
2022-01-24test: update domain test to use mocked resolverfeistel
2022-01-24test: add malformed acme middleware url testfeistel
2022-01-24test: add mocked resolverfeistel
2022-01-24Merge branch 'feat/gci' into 'master'Jaime Martinez
build: add gci linter Closes #671 See merge request gitlab-org/gitlab-pages!643
2022-01-24Merge branch 'require/http-status' into 'master'Jaime Martinez
test: replace http status assertions with testify method See merge request gitlab-org/gitlab-pages!637
2022-01-24lint: fix gci issuesfeistel
2022-01-24Merge branch 'ci/exclude-rules' into 'master'Jaime Martinez
ci: only skip golangci for internal/mocks See merge request gitlab-org/gitlab-pages!661
2022-01-24test: regenerate client mockfeistel
2022-01-24test: update tests to new client stubfeistel
the old client_stub is removed and tests have been updated to table tests
2022-01-24refactor: migrate client stub to mockgenfeistel
2022-01-20fix: fix error message for disabled placeholdersVladimir Shushlin
2022-01-20lint: solve internal/vfs/serving linter issuesfeistel
2022-01-20lint: solve internal/serving/disk/symlink linter issuesfeistel
2022-01-19refactor: remove internal/httputil packagefeistel
2022-01-19feat: switch to content negotiation libraryfeistel
Changelog: changed