Age | Commit message (Collapse) | Author | |
---|---|---|---|
2020-05-28 | Revert goconst changes in auth_test.go | Jaime Martinez | |
2020-05-28 | Add .golangci.yml linter configuration | Jaime Martinez | |
As part of https://gitlab.com/gitlab-org/gitlab-pages/-/issues/385 we have introduced the use of a custom `.golangci.yml` file with some custom rules for linting. This replaces the need of downloading and using `golint`, `gofmt` `go vet` and `gocyclo` manually. We take advantage of the custom `golangci-lint` docker image as stated in the [Automatic lintinb] (https://docs.gitlab.com/ee/development/go_guide/#automatic-linting) section of the Go standards and style guidelines. This iteration enables a subset of linters, with the remaining of them enabled on a separate MR as described in the issue above. The main changes introduced by this linter include: - gosec: potential hardcoded credentials - goconst: DRY by declaring and using constants - gosimple: reduce statements complexity and improve return statements | |||
2020-05-25 | Only use gosect-sast and secrets-sast scans | Jaime Martinez | |
2020-05-19 | Rename flag to domain-config-source | Jaime Martinez | |
2020-05-18 | Add domain-source config flag | Jaime Martinez | |
This is an incremental step for adding `-domain-source` as described in https://gitlab.com/gitlab-org/gitlab/-/issues/217912. We are only adding the flag here but it's not doing anything at the moment. Add TODO for implementation | |||
2020-05-12 | Merge branch 'fix/gb/gitlab-api-reuse-http-connections' into 'master' | Vladimir Shushlin | |
Ensure that we always close GitLab API response body See merge request gitlab-org/gitlab-pages!275 | |||
2020-05-12 | Ensure that we always close GitLab API response body | Grzegorz Bizon | |
This change is important because in case of receiving a JSON payload from GitLab API that is invalid, and is larger than 512, deserializer will stop reading it after 512 bytes and will not close the reader. This will result in HTTP connection not being reused. This commit ensures that we always read reasponse body until EOF and that we close the reader afterwards. | |||
2020-05-08 | Test that standart arguments are allowed260-secrets-from-file-only | Vladimir Shushlin | |
2020-05-08 | Consolidate args validation | Jaime Martinez | |
2020-05-08 | Enforce loading secrets from file | Jaime Martinez | |
Passing secrets via command line is not allowed anymore. A config file should be used instead. The default filename is `gitlab-pages-config`. The following command line options will throw an error and prevent pages from running if set explicitly: - `-auth-client-id` - `-auth-client-secret` - `-auth-secret` | |||
2020-05-08 | Fix deprecated args validation | Jaime Martinez | |
Fixes check for deprecated arguments to cater for key=value arugments. It also logs the warning if a deprecated flag is used. | |||
2020-05-08 | explicitly set MaxIdleConns, so that it is clear we need to update it when ↵ | Igor | |
increasing MaxIdleConnsPerHost | |||
2020-04-30 | change back to internal-gitlab-server as per @@vshushlin | Igor Wiedler | |
2020-04-30 | rename GitlabServerURL to GitlabAPIServerURL (as per @@krasio) | Igor Wiedler | |
2020-04-30 | rename internal-gitlab-server to gitlab-api-server (as per @@krasio) | Igor Wiedler | |
2020-04-29 | introduce separate config flag internal-gitlab-server | Igor Wiedler | |
2020-03-30 | Remove obsolete test case for gitlab source cache | Grzegorz Bizon | |
2020-03-27 | Fix gitlab source cache tests duration | Grzegorz Bizon | |
This reduces tests duration from 30sec to milliseconds. | |||
2020-03-10 | Update special characters test to lowercase | Catalin Irimie | |
2020-03-06 | Encode artifact path to fix wrongly generated URLs | Catalin Irimie | |
2020-03-05 | Merge branch 'support-go-1-14' into 'master' | Vladimir Shushlin | |
Add golang:1.14 tests in CI and fix GitLab source client test See merge request gitlab-org/gitlab-pages!250 | |||
2020-03-04 | Merge branch '350-healthcheck-middleware' into 'master' | Alessio Caiazza | |
Extract health check in its own middleware See merge request gitlab-org/gitlab-pages!247 | |||
2020-03-04 | Increase GitLab internal API response timeout | Grzegorz Bizon | |
2020-03-03 | Add default cache configuration and pass down to memstore and Entry. | Jaime Martinez | |
Wrap global variables into one default struct. Update test steps so that tests run every time so we don't get the cached results. | |||
2020-02-28 | Merge branch 'backstage/gb/add-ensure-certs-benchmark' into 'master' | Alessio Caiazza | |
Add benchmark for throughput on ensuring domain certs See merge request gitlab-org/gitlab-pages!251 | |||
2020-02-28 | Merge branch 'feature/gb/serverless-serving-enable' into 'master' | Alessio Caiazza | |
Enable serverless serving See merge request gitlab-org/gitlab-pages!232 | |||
2020-02-28 | Add benchmark for throughput on ensuring domain certs | Grzegorz Bizon | |
2020-02-28 | Avoid implicit delegation in disk serving | Grzegorz Bizon | |
2020-02-28 | Add golang:1.14 tests in CI and fix GitLab source client test | Jaime Martinez | |
2020-02-28 | Extract health check in its own middleware | Krasimir Angelov | |
This way we short-circuit health check requests and avoid doing domain lookup for them. We also do not report them in exported Prometheus metrics and this way avoid trigger alerts during deploys. Related to: * https://gitlab.com/gitlab-org/gitlab-pages/issues/350 * https://gitlab.com/gitlab-com/gl-infra/production/issues/1681 | |||
2020-02-27 | Improve comments and code readability | Grzegorz Bizon | |
2020-02-26 | Skip racy test | Alessio Caiazza | |
2020-02-26 | Fix data race on cache.client struct | Alessio Caiazza | |
2020-02-24 | Log an error when a serving can not be fabricated | Grzegorz Bizon | |
2020-02-24 | Move serving and lookup path factory to source package | Grzegorz Bizon | |
2020-02-24 | Improve code quality and add a few missing comments | Grzegorz Bizon | |
2020-02-19 | Remove request.WithHTTPSFlag and set directly in tests | Jaime Martinez | |
2020-02-18 | Fix go imports in factory lookup_path.go file | Grzegorz Bizon | |
2020-02-18 | Simplify serverless serving and add a few tests | Grzegorz Bizon | |
2020-02-18 | Add tests for gitlab source lookup path factory | Grzegorz Bizon | |
2020-02-18 | Enable serverless domains source | Grzegorz Bizon | |
2020-02-18 | Ensure that we not do return nil serving.Request | Grzegorz Bizon | |
2020-02-17 | Remove ctxHTTPSKey from the context completely | Jaime Martinez | |
2020-02-12 | Merge branch 'master' into feature/gb/serverless-serving-enable | Grzegorz Bizon | |
* master: Add prometheus metrics for GitLab API client Fix benchmarks Freeze tools version Add acceptance test for serverless metrics Update documentation on using Gorilla ProxyHeaders use gorilla/handlers.ProxyHeaders to get the X-Forwarded-* headers and set them in the appropriate http.Request fields Apply suggestion to metrics/metrics.go Add serverless serving metrics Conflicts: internal/serving/serverless/serverless.go | |||
2020-02-12 | Make it possible to fabricate a serverless serving | Grzegorz Bizon | |
2020-02-12 | Add GitLab API definition for serverless serving | Grzegorz Bizon | |
2020-02-11 | Memoize disk serving on a package level | Grzegorz Bizon | |
2020-02-11 | Make it possible to fabricate serving per request | Grzegorz Bizon | |
2020-02-11 | Add prometheus metrics for GitLab API client | Jaime Martinez | |
Refactor metrics initialization removing init function from the metrics package. | |||
2020-02-07 | Rename lookup variable in domain struct function | Grzegorz Bizon | |