Age | Commit message (Collapse) | Author |
|
This reverts commit 185e0a0e5c621f350335495291c535e5c05df89b, reversing
changes made to a3365a7b1b41b3dee206cbcf27e915ee45d556a5.
|
|
This reverts merge request !305
|
|
|
|
|
|
As part of https://gitlab.com/gitlab-org/gitlab-pages/-/issues/385
we have introduced the use of a custom `.golangci.yml` file with some
custom rules for linting.
This replaces the need of downloading and using `golint`, `gofmt`
`go vet` and `gocyclo` manually. We take advantage of the custom
`golangci-lint` docker image as stated in the [Automatic lintinb]
(https://docs.gitlab.com/ee/development/go_guide/#automatic-linting)
section of the Go standards and style guidelines.
This iteration enables a subset of linters, with the remaining
of them enabled on a separate MR as described in the issue above.
The main changes introduced by this linter include:
- gosec: potential hardcoded credentials
- goconst: DRY by declaring and using constants
- gosimple: reduce statements complexity and improve return statements
|
|
|
|
This is an incremental step for adding `-domain-source`
as described in https://gitlab.com/gitlab-org/gitlab/-/issues/217912.
We are only adding the flag here but it's not doing anything at the
moment.
Add TODO for implementation
|
|
Passing secrets via command line is not allowed anymore.
A config file should be used instead. The default filename is
`gitlab-pages-config`. The following command line options will
throw an error and prevent pages from running if set explicitly:
- `-auth-client-id`
- `-auth-client-secret`
- `-auth-secret`
|
|
Fixes check for deprecated arguments to cater
for key=value arugments. It also logs the warning
if a deprecated flag is used.
|
|
|
|
|
|
|
|
|
|
Refactor metrics initialization removing init function
from the metrics package.
|
|
This adds support for specifying rollout strategy via the following
attributes:
* percentage - integer value that specifies how many % of requests
should be enabled
* stickiness - if not specified guarantees stickiness for the provided
actor. If set to "random" no stickiness is guaranteed.
|
|
|
|
|
|
before using it.
|
|
|
|
|
|
as GitLabAPISecretKey
|
|
Related to https://gitlab.com/gitlab-org/gitlab/issues/28781 and
https://gitlab.com/gitlab-org/gitlab-pages/issues/253.
|
|
Secrets should not be given on command line
See merge request gitlab-org/gitlab-pages!182
|
|
|
|
It was ever used. See
gitlab-org/omnibus-gitlab/merge_requests/3444#note_194217889 for more
details.
Done as part of https://gitlab.com/gitlab-org/gitlab/issues/28781.
|
|
|
|
|
|
This reverts commit 27bd4d83cade6a721330e8583874e7c715bf3a26.
|
|
|
|
Introduce two new configuration options -tls-min-version and
-tls-max-version to control which TLS versions will be supported by the
server. Accepted values are ssl3, tls1.0, tls1.1, tls1.2, and tls1.3.
Closing https://gitlab.com/gitlab-org/gitlab-pages/issues/187
|
|
Supported cipher suites:
tls.TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305
tls.TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305
tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
tls.TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256
tls.TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
tls.TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384
Closes https://gitlab.com/gitlab-org/gitlab-pages/issues/150.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
In the parent of this commit, I've added a new flag implementation to
support config using env vars or a config file. This commits add support
for multiflag value setting, when using a csv like structure for those
values.
This was needed as for those only the first value was being read.
|
|
|
|
|
|
|
|
|
|
redirect-http seemed to suggest the Pages daemon would redirect from HTTPS to
HTTP, but it seems that the opposite was implied.
Fixes issue manifested by https://gitlab.com/gitlab-org/omnibus-gitlab/merge_requests/1348
|
|
Also fixed the dependencies, moved metrics to its own package and
updated the tests
|
|
This starts of the prometheus monitoring for GitLab Pages, and
resolves gitlab-org/gitlab-pages#42
Point to check:
- Are the metric names good, keeping Prometheus' conventions in mind?
- Golang, general style etc
- Shouldn't I do some voodoo magic to import this in the library?
|
|
Per issue #13, sometimes you want to listen on more than one port for each type
of listener. This commit adds support for that.
|