From 11b5932d1f41d6b9f46331ef97d427948ed00712 Mon Sep 17 00:00:00 2001 From: Jaime Martinez Date: Tue, 31 Mar 2020 17:04:15 +1100 Subject: Serve custom 404.html file for namespace domains This will allow namespace domains to serve custom 404.html files for public projects. This change adds a check to check for permision only if it's serving a namespace domain with access controls enabled. --- acceptance_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'acceptance_test.go') diff --git a/acceptance_test.go b/acceptance_test.go index e8f7fe1a..67558964 100644 --- a/acceptance_test.go +++ b/acceptance_test.go @@ -1214,7 +1214,7 @@ func TestAccessControlGroupDomain404RedirectsAuth(t *testing.T) { teardown := RunPagesProcessWithAuth(t, *pagesBinary, listeners, "") defer teardown() - rsp, err := GetRedirectPage(t, httpListener, "group.gitlab-example.com", "/nonexistent/") + rsp, err := GetRedirectPage(t, httpListener, "group.auth.gitlab-example.com", "/nonexistent/") require.NoError(t, err) defer rsp.Body.Close() require.Equal(t, http.StatusFound, rsp.StatusCode) -- cgit v1.2.3