From 51e351cd1ac6727f29acb13826b60b862541dfcb Mon Sep 17 00:00:00 2001 From: feistel <6742251-feistel@users.noreply.gitlab.com> Date: Mon, 22 Nov 2021 21:17:35 +0100 Subject: lint: remove outdated nolint directives --- internal/handlers/handlers_test.go | 5 ----- 1 file changed, 5 deletions(-) (limited to 'internal/handlers') diff --git a/internal/handlers/handlers_test.go b/internal/handlers/handlers_test.go index a5044d09..d71e9b91 100644 --- a/internal/handlers/handlers_test.go +++ b/internal/handlers/handlers_test.go @@ -74,7 +74,6 @@ func TestNotFoundWithTokenIsNotHandled(t *testing.T) { reqURL, _ := url.Parse("/") r := &http.Request{URL: reqURL} response := &http.Response{StatusCode: http.StatusNotFound} - // nolint:bodyclose // TODO investigate https://gitlab.com/gitlab-org/gitlab-pages/-/issues/606 handled := handlers.checkIfLoginRequiredOrInvalidToken(w, r, "token")(response) require.False(t, handled) @@ -116,7 +115,6 @@ func TestForbiddenWithTokenIsNotHandled(t *testing.T) { w := httptest.NewRecorder() r := httptest.NewRequest(http.MethodGet, "/", nil) response := &http.Response{StatusCode: tc.StatusCode} - // nolint:bodyclose // TODO investigate https://gitlab.com/gitlab-org/gitlab-pages/-/issues/606 handled := handlers.checkIfLoginRequiredOrInvalidToken(w, r, tc.Token)(response) require.Equal(t, tc.Handled, handled) @@ -135,7 +133,6 @@ func TestNotFoundWithoutTokenIsNotHandledWhenNotAuthSupport(t *testing.T) { w := httptest.NewRecorder() r := httptest.NewRequest(http.MethodGet, "/", nil) response := &http.Response{StatusCode: http.StatusNotFound} - // nolint:bodyclose // TODO investigate https://gitlab.com/gitlab-org/gitlab-pages/-/issues/606 handled := handlers.checkIfLoginRequiredOrInvalidToken(w, r, "")(response) require.False(t, handled) @@ -152,7 +149,6 @@ func TestNotFoundWithoutTokenIsHandled(t *testing.T) { w := httptest.NewRecorder() r := httptest.NewRequest(http.MethodGet, "/", nil) response := &http.Response{StatusCode: http.StatusNotFound} - // nolint:bodyclose // TODO investigate https://gitlab.com/gitlab-org/gitlab-pages/-/issues/606 handled := handlers.checkIfLoginRequiredOrInvalidToken(w, r, "")(response) require.True(t, handled) @@ -169,7 +165,6 @@ func TestInvalidTokenResponseIsHandled(t *testing.T) { w := httptest.NewRecorder() r := httptest.NewRequest(http.MethodGet, "/", nil) response := &http.Response{StatusCode: http.StatusUnauthorized} - // nolint:bodyclose // TODO investigate https://gitlab.com/gitlab-org/gitlab-pages/-/issues/606 handled := handlers.checkIfLoginRequiredOrInvalidToken(w, r, "token")(response) require.True(t, handled) -- cgit v1.2.3