From a0c218ff6a0cd18b5fba6481c3de7629f6527182 Mon Sep 17 00:00:00 2001 From: Grzegorz Bizon Date: Wed, 11 Dec 2019 15:40:27 +0100 Subject: Remove retrieval context that might mask problems --- internal/source/gitlab/cache/cache_test.go | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'internal/source/gitlab/cache/cache_test.go') diff --git a/internal/source/gitlab/cache/cache_test.go b/internal/source/gitlab/cache/cache_test.go index 7abcb09d..ac7c6726 100644 --- a/internal/source/gitlab/cache/cache_test.go +++ b/internal/source/gitlab/cache/cache_test.go @@ -207,9 +207,9 @@ func TestResolve(t *testing.T) { }) }) - t.Run("when retrieval failed because of an external context timeout", func(t *testing.T) { - ctx, cancel := context.WithDeadline(context.Background(), time.Now().Add(-time.Hour)) - defer cancel() + t.Run("when retrieval failed because of an external context being canceled", func(t *testing.T) { + ctx, cancel := context.WithCancel(context.Background()) + cancel() withTestCache(resolverConfig{}, func(cache *Cache, resolver *client) { lookup := cache.Resolve(ctx, "my.gitlab.com") @@ -219,7 +219,7 @@ func TestResolve(t *testing.T) { }) }) - t.Run("when retrieval failed because of an internal context timeout", func(t *testing.T) { + t.Run("when retrieval failed because of an internal retriever context timeout", func(t *testing.T) { retrievalTimeout = 0 defer func() { retrievalTimeout = 5 * time.Second }() @@ -227,7 +227,7 @@ func TestResolve(t *testing.T) { lookup := cache.Resolve(context.Background(), "my.gitlab.com") require.Equal(t, uint64(0), resolver.lookups) - require.EqualError(t, lookup.Error, "context done") + require.EqualError(t, lookup.Error, "retrieval context done") }) }) -- cgit v1.2.3