1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
|
package domain
import (
"fmt"
"io/ioutil"
"net/http"
"net/http/httptest"
"os"
"testing"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitlab-pages/internal/fixture"
"gitlab.com/gitlab-org/gitlab-pages/internal/serving"
"gitlab.com/gitlab-org/gitlab-pages/internal/serving/disk"
"gitlab.com/gitlab-org/gitlab-pages/internal/testhelpers"
)
type stubbedResolver struct {
project *serving.LookupPath
subpath string
err error
}
func (resolver *stubbedResolver) Resolve(*http.Request) (*serving.Request, error) {
return &serving.Request{
Serving: disk.New(),
LookupPath: resolver.project,
SubPath: resolver.subpath,
}, resolver.err
}
func serveFileOrNotFound(domain *Domain) http.HandlerFunc {
return func(w http.ResponseWriter, r *http.Request) {
if !domain.ServeFileHTTP(w, r) {
domain.ServeNotFoundHTTP(w, r)
}
}
}
func TestIsHTTPSOnly(t *testing.T) {
tests := []struct {
name string
domain *Domain
url string
expected bool
}{
{
name: "Custom domain with HTTPS-only enabled",
domain: &Domain{
Resolver: &stubbedResolver{
project: &serving.LookupPath{
Path: "group/project/public",
IsHTTPSOnly: true,
},
},
},
url: "http://custom-domain",
expected: true,
},
{
name: "Custom domain with HTTPS-only disabled",
domain: &Domain{
Resolver: &stubbedResolver{
project: &serving.LookupPath{
Path: "group/project/public",
IsHTTPSOnly: false,
},
},
},
url: "http://custom-domain",
expected: false,
},
{
name: "Unknown project",
domain: &Domain{},
url: "http://test-domain/project",
expected: false,
},
}
for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
req, _ := http.NewRequest(http.MethodGet, test.url, nil)
require.Equal(t, test.expected, test.domain.IsHTTPSOnly(req))
})
}
}
func TestPredefined404ServeHTTP(t *testing.T) {
cleanup := setUpTests(t)
defer cleanup()
testDomain := &Domain{}
testhelpers.AssertHTTP404(t, serveFileOrNotFound(testDomain), "GET", "http://group.test.io/not-existing-file", nil, "The page you're looking for could not be found")
}
func TestGroupCertificate(t *testing.T) {
testGroup := &Domain{}
tls, err := testGroup.EnsureCertificate()
require.Nil(t, tls)
require.Error(t, err)
}
func TestDomainNoCertificate(t *testing.T) {
testDomain := &Domain{
Name: "test.domain.com",
}
tls, err := testDomain.EnsureCertificate()
require.Nil(t, tls)
require.Error(t, err)
_, err2 := testDomain.EnsureCertificate()
require.Error(t, err)
require.Equal(t, err, err2)
}
func BenchmarkEnsureCertificate(b *testing.B) {
for i := 0; i < b.N; i++ {
testDomain := &Domain{
Name: "test.domain.com",
CertificateCert: fixture.Certificate,
CertificateKey: fixture.Key,
}
testDomain.EnsureCertificate()
}
}
var chdirSet = false
func setUpTests(t require.TestingT) func() {
return chdirInPath(t, "../../shared/pages")
}
func chdirInPath(t require.TestingT, path string) func() {
noOp := func() {}
if chdirSet {
return noOp
}
cwd, err := os.Getwd()
require.NoError(t, err, "Cannot Getwd")
err = os.Chdir(path)
require.NoError(t, err, "Cannot Chdir")
chdirSet = true
return func() {
err := os.Chdir(cwd)
require.NoError(t, err, "Cannot Chdir in cleanup")
chdirSet = false
}
}
func TestDomain_ServeNamespaceNotFound(t *testing.T) {
// defaultNotFound := "The page you're looking for could not be found."
// customNotFound := "Custom error page"
tests := []struct {
name string
domain string
path string
resolver *stubbedResolver
expectedResponse string
}{
{
name: "public_namespace_domain",
domain: "group.404.gitlab-example.com",
path: "/unknown",
resolver: &stubbedResolver{
project: &serving.LookupPath{
Path: "../../shared/pages/group.404/group.404.gitlab-example.com/public",
IsNamespaceProject: true,
},
subpath: "/unknown",
},
expectedResponse: "Custom 404 group page",
},
{
name: "private_project_under_public_namespace_domain",
domain: "group.404.gitlab-example.com",
path: "/private_project/unknown",
resolver: &stubbedResolver{
project: &serving.LookupPath{
Path: "../../shared/pages/group.404/group.404.gitlab-example.com/public",
IsNamespaceProject: true,
HasAccessControl: false,
},
subpath: "/",
},
expectedResponse: "Custom 404 group page",
},
{
name: "private_namespace_domain",
domain: "group.404.gitlab-example.com",
path: "/unknown",
resolver: &stubbedResolver{
project: &serving.LookupPath{
Path: "../../shared/pages/group.404/group.404.gitlab-example.com/public",
IsNamespaceProject: true,
HasAccessControl: true,
},
subpath: "/",
},
expectedResponse: "The page you're looking for could not be found.",
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
d := &Domain{
Name: tt.domain,
Resolver: tt.resolver,
}
w := httptest.NewRecorder()
r := httptest.NewRequest("GET", fmt.Sprintf("http://%s%s", tt.domain, tt.path), nil)
d.ServeNamespaceNotFound(w, r)
resp := w.Result()
require.Equal(t, http.StatusNotFound, resp.StatusCode)
body, err := ioutil.ReadAll(resp.Body)
require.NoError(t, err)
require.Contains(t, string(body), tt.expectedResponse)
})
}
}
|
