1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
|
package gitlab
import (
"context"
"net/http/httptest"
"testing"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitlab-pages/internal/source/gitlab/api"
"gitlab.com/gitlab-org/gitlab-pages/internal/source/gitlab/client"
)
func TestGetDomain(t *testing.T) {
t.Run("when the response if correct", func(t *testing.T) {
client := client.StubClient{File: "client/testdata/test.gitlab.io.json"}
source := Gitlab{client: client}
domain, err := source.GetDomain(context.Background(), "test.gitlab.io")
require.NoError(t, err)
require.Equal(t, "test.gitlab.io", domain.Name)
})
t.Run("when the response is not valid", func(t *testing.T) {
client := client.StubClient{File: "/dev/null"}
source := Gitlab{client: client}
domain, err := source.GetDomain(context.Background(), "test.gitlab.io")
require.NotNil(t, err)
require.Nil(t, domain)
})
t.Run("when pages endpoint is unauthorized", func(t *testing.T) {
c := client.StubClient{Lookup: &api.Lookup{Error: client.ErrUnauthorizedAPI}}
source := Gitlab{client: c}
_, err := source.GetDomain(context.Background(), "test")
require.EqualError(t, err, client.ErrUnauthorizedAPI.Error())
require.False(t, source.IsReady())
})
}
func TestResolve(t *testing.T) {
client := client.StubClient{File: "client/testdata/test.gitlab.io.json"}
source := Gitlab{client: client, enableDisk: true}
t.Run("when requesting nested group project with root path", func(t *testing.T) {
target := "https://test.gitlab.io:443/my/pages/project/"
request := httptest.NewRequest("GET", target, nil)
response, err := source.Resolve(request)
require.NoError(t, err)
require.Equal(t, "/my/pages/project/", response.LookupPath.Prefix)
require.Equal(t, "some/path/to/project/", response.LookupPath.Path)
require.Equal(t, "", response.SubPath)
require.False(t, response.LookupPath.IsNamespaceProject)
})
t.Run("when requesting a nested group project with full path", func(t *testing.T) {
target := "https://test.gitlab.io:443/my/pages/project/path/index.html"
request := httptest.NewRequest("GET", target, nil)
response, err := source.Resolve(request)
require.NoError(t, err)
require.Equal(t, "/my/pages/project/", response.LookupPath.Prefix)
require.Equal(t, "some/path/to/project/", response.LookupPath.Path)
require.Equal(t, "path/index.html", response.SubPath)
require.False(t, response.LookupPath.IsNamespaceProject)
})
t.Run("when requesting the group root project with root path", func(t *testing.T) {
target := "https://test.gitlab.io:443/"
request := httptest.NewRequest("GET", target, nil)
response, err := source.Resolve(request)
require.NoError(t, err)
require.Equal(t, "/", response.LookupPath.Prefix)
require.Equal(t, "some/path/to/project-3/", response.LookupPath.Path)
require.Equal(t, "", response.SubPath)
require.True(t, response.LookupPath.IsNamespaceProject)
})
t.Run("when requesting the group root project with full path", func(t *testing.T) {
target := "https://test.gitlab.io:443/path/to/index.html"
request := httptest.NewRequest("GET", target, nil)
response, err := source.Resolve(request)
require.NoError(t, err)
require.Equal(t, "/", response.LookupPath.Prefix)
require.Equal(t, "path/to/index.html", response.SubPath)
require.Equal(t, "some/path/to/project-3/", response.LookupPath.Path)
require.True(t, response.LookupPath.IsNamespaceProject)
})
t.Run("when request path has not been sanitized", func(t *testing.T) {
target := "https://test.gitlab.io:443/something/../something/../my/pages/project/index.html"
request := httptest.NewRequest("GET", target, nil)
response, err := source.Resolve(request)
require.NoError(t, err)
require.Equal(t, "/my/pages/project/", response.LookupPath.Prefix)
require.Equal(t, "index.html", response.SubPath)
})
}
// Test proves fix for https://gitlab.com/gitlab-org/gitlab-pages/-/issues/576
func TestResolveLookupPathsOrderDoesNotMatter(t *testing.T) {
client := client.StubClient{File: "client/testdata/group-first.gitlab.io.json"}
source := Gitlab{client: client, enableDisk: true}
tests := map[string]struct {
target string
expectedPrefix string
expectedPath string
expectedSubPath string
expectedIsNamespace bool
}{
"when requesting the group root project with root path": {
target: "https://group-first.gitlab.io:443/",
expectedPrefix: "/",
expectedPath: "some/path/group/",
expectedSubPath: "",
expectedIsNamespace: true,
},
"when requesting another project with path": {
target: "https://group-first.gitlab.io:443/my/second-project/index.html",
expectedPrefix: "/my/second-project/",
expectedPath: "some/path/to/project-2/",
expectedSubPath: "index.html",
expectedIsNamespace: false,
},
}
for name, test := range tests {
t.Run(name, func(t *testing.T) {
request := httptest.NewRequest("GET", test.target, nil)
response, err := source.Resolve(request)
require.NoError(t, err)
require.Equal(t, test.expectedPrefix, response.LookupPath.Prefix)
require.Equal(t, test.expectedPath, response.LookupPath.Path)
require.Equal(t, test.expectedSubPath, response.SubPath)
require.Equal(t, test.expectedIsNamespace, response.LookupPath.IsNamespaceProject)
})
}
}
|
