diff options
author | Daniel Lublin <daniel@lublin.se> | 2020-06-13 16:24:37 +0300 |
---|---|---|
committer | Daniel Lublin <daniel@lublin.se> | 2020-06-13 16:24:37 +0300 |
commit | 34d89d0f8272e3379f4b7f7a2f355698c5635430 (patch) | |
tree | b8590c525d4ca3259dae211f8258bf9e691fdb7a | |
parent | 8aa2b0d791a433665bdbaba78dad4a88be730fe5 (diff) |
Don't throw is stopping threads twice
This crash has been seen. Seems OK to be a bit kinder regarding
stopThreads(). Not touching startThreads() for now.
-rw-r--r-- | src/main/java/se/lublin/humla/net/HumlaNetworkThread.java | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/src/main/java/se/lublin/humla/net/HumlaNetworkThread.java b/src/main/java/se/lublin/humla/net/HumlaNetworkThread.java index 028f4fc..68ecfed 100644 --- a/src/main/java/se/lublin/humla/net/HumlaNetworkThread.java +++ b/src/main/java/se/lublin/humla/net/HumlaNetworkThread.java @@ -19,10 +19,13 @@ package se.lublin.humla.net; import android.os.Handler; import android.os.Looper; +import android.util.Log; import java.util.concurrent.ExecutorService; import java.util.concurrent.Executors; +import se.lublin.humla.Constants; + /** * Base class for TCP/UDP protocol implementations. * Provides a common threading model (single threaded queue for write) @@ -54,7 +57,9 @@ public abstract class HumlaNetworkThread implements Runnable { protected void stopThreads() { if (!mInitialized) { - throw new IllegalArgumentException("Threads already shutdown."); + // TODO? Used throw, like startThreads() + Log.e(Constants.TAG, "Error in stopThreads: Threads already shutdown"); + return; } mSendExecutor.shutdown(); mReceiveExecutor.shutdownNow(); |