From f21a38e1f671ebce5dec4567d191480ba18ed3cf Mon Sep 17 00:00:00 2001 From: Daniel Lublin Date: Fri, 8 May 2020 12:56:56 +0200 Subject: Lint more --- build.gradle | 7 +++++++ .../java/se/lublin/humla/audio/InvalidSampleRateException.java | 3 ++- src/main/java/se/lublin/humla/exception/AudioException.java | 1 + .../se/lublin/humla/exception/AudioInitializationException.java | 1 + src/main/java/se/lublin/humla/exception/NativeAudioException.java | 1 + src/main/java/se/lublin/humla/exception/NotConnectedException.java | 1 + .../java/se/lublin/humla/exception/NotSynchronizedException.java | 1 + src/main/java/se/lublin/humla/net/HumlaConnection.java | 2 +- src/main/java/se/lublin/humla/util/HumlaDisconnectedException.java | 1 + src/main/java/se/lublin/humla/util/HumlaException.java | 1 + 10 files changed, 17 insertions(+), 2 deletions(-) diff --git a/build.gradle b/build.gradle index f0fd30e..aa6b925 100644 --- a/build.gradle +++ b/build.gradle @@ -15,6 +15,13 @@ * along with this program. If not, see . */ +allprojects { + tasks.withType(JavaCompile) { + // TODO include deprecations at some point, but currently they are *many* + options.compilerArgs << "-Xlint:all" << "-Xlint:-deprecation" << "-Xlint:-dep-ann" + } +} + buildscript { repositories { jcenter() diff --git a/src/main/java/se/lublin/humla/audio/InvalidSampleRateException.java b/src/main/java/se/lublin/humla/audio/InvalidSampleRateException.java index 7a29da1..3bac010 100644 --- a/src/main/java/se/lublin/humla/audio/InvalidSampleRateException.java +++ b/src/main/java/se/lublin/humla/audio/InvalidSampleRateException.java @@ -20,7 +20,8 @@ package se.lublin.humla.audio; /** * Created by andrew on 23/04/14. */ -public class InvalidSampleRateException extends Exception { +@SuppressWarnings("serial") + public class InvalidSampleRateException extends Exception { public InvalidSampleRateException(Exception e) { super(e); } diff --git a/src/main/java/se/lublin/humla/exception/AudioException.java b/src/main/java/se/lublin/humla/exception/AudioException.java index 6cdfafa..0549552 100644 --- a/src/main/java/se/lublin/humla/exception/AudioException.java +++ b/src/main/java/se/lublin/humla/exception/AudioException.java @@ -20,6 +20,7 @@ package se.lublin.humla.exception; /** * Created by andrew on 28/04/14. */ +@SuppressWarnings("serial") public class AudioException extends Exception { public AudioException(String message) { super(message); diff --git a/src/main/java/se/lublin/humla/exception/AudioInitializationException.java b/src/main/java/se/lublin/humla/exception/AudioInitializationException.java index 7a3b77b..8851a1c 100644 --- a/src/main/java/se/lublin/humla/exception/AudioInitializationException.java +++ b/src/main/java/se/lublin/humla/exception/AudioInitializationException.java @@ -20,6 +20,7 @@ package se.lublin.humla.exception; /** * Created by andrew on 28/04/14. */ +@SuppressWarnings("serial") public class AudioInitializationException extends AudioException { public AudioInitializationException(String message) { super(message); diff --git a/src/main/java/se/lublin/humla/exception/NativeAudioException.java b/src/main/java/se/lublin/humla/exception/NativeAudioException.java index f1e67b0..4143530 100644 --- a/src/main/java/se/lublin/humla/exception/NativeAudioException.java +++ b/src/main/java/se/lublin/humla/exception/NativeAudioException.java @@ -20,6 +20,7 @@ package se.lublin.humla.exception; /** * Created by andrew on 07/03/14. */ +@SuppressWarnings("serial") public class NativeAudioException extends AudioException { public NativeAudioException(String message) { super(message); diff --git a/src/main/java/se/lublin/humla/exception/NotConnectedException.java b/src/main/java/se/lublin/humla/exception/NotConnectedException.java index 928e129..68a88dc 100644 --- a/src/main/java/se/lublin/humla/exception/NotConnectedException.java +++ b/src/main/java/se/lublin/humla/exception/NotConnectedException.java @@ -21,6 +21,7 @@ package se.lublin.humla.exception; * Thrown when a Humla connection has not yet been established. * Created by andrew on 24/10/15. */ +@SuppressWarnings("serial") public class NotConnectedException extends Exception { public NotConnectedException() { super("Not yet connected"); diff --git a/src/main/java/se/lublin/humla/exception/NotSynchronizedException.java b/src/main/java/se/lublin/humla/exception/NotSynchronizedException.java index 119adbb..742a057 100644 --- a/src/main/java/se/lublin/humla/exception/NotSynchronizedException.java +++ b/src/main/java/se/lublin/humla/exception/NotSynchronizedException.java @@ -21,6 +21,7 @@ package se.lublin.humla.exception; * Called when Humla has not yet received the ServerSync message from the server. * Created by andrew on 24/10/15. */ +@SuppressWarnings("serial") public class NotSynchronizedException extends Exception { public NotSynchronizedException() { super("Not yet synchronized"); diff --git a/src/main/java/se/lublin/humla/net/HumlaConnection.java b/src/main/java/se/lublin/humla/net/HumlaConnection.java index 57ff570..caabcb6 100644 --- a/src/main/java/se/lublin/humla/net/HumlaConnection.java +++ b/src/main/java/se/lublin/humla/net/HumlaConnection.java @@ -92,7 +92,7 @@ public class HumlaConnection implements HumlaTCP.TCPConnectionListener, HumlaUDP // Networking and protocols private HumlaTCP mTCP; private HumlaUDP mUDP; - private ScheduledFuture mPingTask; + private ScheduledFuture mPingTask; private boolean mUsingUDP = true; private boolean mForceTCP; private boolean mUseTor; diff --git a/src/main/java/se/lublin/humla/util/HumlaDisconnectedException.java b/src/main/java/se/lublin/humla/util/HumlaDisconnectedException.java index 161d449..dffdf18 100644 --- a/src/main/java/se/lublin/humla/util/HumlaDisconnectedException.java +++ b/src/main/java/se/lublin/humla/util/HumlaDisconnectedException.java @@ -5,6 +5,7 @@ package se.lublin.humla.util; * Created by andrew on 01/03/17. */ +@SuppressWarnings("serial") public class HumlaDisconnectedException extends RuntimeException { public HumlaDisconnectedException() { super("Caller attempted to use the protocol while disconnected."); diff --git a/src/main/java/se/lublin/humla/util/HumlaException.java b/src/main/java/se/lublin/humla/util/HumlaException.java index b392fb6..74c19a2 100644 --- a/src/main/java/se/lublin/humla/util/HumlaException.java +++ b/src/main/java/se/lublin/humla/util/HumlaException.java @@ -25,6 +25,7 @@ import se.lublin.humla.protobuf.Mumble; /** * Created by andrew on 14/07/13. */ +@SuppressWarnings("serial") public class HumlaException extends Exception implements Parcelable { public static final Creator CREATOR = new Creator() { -- cgit v1.2.3