diff options
| author | François Laignel <fengalin@free.fr> | 2021-12-14 21:40:27 +0300 |
|---|---|---|
| committer | Sebastian Dröge <slomo@coaxion.net> | 2021-12-25 14:25:56 +0300 |
| commit | 6163589ac7f9809903c9d52a3b0591de77e722c8 (patch) | |
| tree | ba9aa19bbbb99b650745cd12244488d9ff17bff1 /generic/threadshare/src/queue | |
| parent | db9c38aa9386c825ac917e77b321b99b12d454e7 (diff) | |
ts/executor: replace tokio with smol-like implementation
The threadshare executor was based on a modified version of tokio
which implemented the throttling strategy in the BasicScheduler.
Upstream tokio codebase has significantly diverged from what it
was when the throttling strategy was implemented making it hard
to follow. This means that we can hardly get updates from the
upstream project and when we cherry pick fixes, we can't reflect
the state of the project on our fork's version. As a consequence,
tools such as cargo-deny can't check for RUSTSEC fixes in our fork.
The smol ecosystem makes it quite easy to implement and maintain
a custom async executor. This MR imports the smol parts that
need modifications to comply with the threadshare model and implements
a throttling executor in place of the tokio fork.
Networking tokio specific types are replaced with Async wrappers
in the spirit of [smol-rs/async-io]. Note however that the Async
wrappers needed modifications in order to use the per thread
Reactor model. This means that higher level upstream networking
crates such as [async-net] can not be used with our Async
implementation.
Based on the example benchmark with ts-udpsrc, performances seem on par
with what we achieved using the tokio fork.
Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/issues/118
Related to https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/604
Diffstat (limited to 'generic/threadshare/src/queue')
| -rw-r--r-- | generic/threadshare/src/queue/imp.rs | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/generic/threadshare/src/queue/imp.rs b/generic/threadshare/src/queue/imp.rs index c4b928728..b01c03711 100644 --- a/generic/threadshare/src/queue/imp.rs +++ b/generic/threadshare/src/queue/imp.rs @@ -789,7 +789,7 @@ impl ObjectImpl for Queue { settings.context = value .get::<Option<String>>() .expect("type checked upstream") - .unwrap_or_else(|| "".into()); + .unwrap_or_else(|| DEFAULT_CONTEXT.into()); } "context-wait" => { settings.context_wait = Duration::from_millis( |