Welcome to mirror list, hosted at ThFree Co, Russian Federation.

cygwin.com/git/newlib-cygwin.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMike Frysinger <vapier@gentoo.org>2022-02-04 09:17:54 +0300
committerMike Frysinger <vapier@gentoo.org>2022-02-05 03:33:29 +0300
commit67c600b99545390c9ebaf96a84f47c3614e492ce (patch)
tree83cf6e07f573946fa817e5233bcafc9547809457 /libgloss/arm
parent899cf3c9529d21e56fb062324c0396d51a3566e6 (diff)
libgloss: restore multilib settings in subdir makefiles
Commit 754f8def0dfeeb43afa5a96ad1971fd0ef02c419 ("libgloss: merge stub arch configure scripts up a level") had an unintended side-effect: the MULTI* variables in the Makefiles no longer get rewritten at configure time in the subdirs. Only the top-level Makefile still is. This is because the configure integration of multilib (both the way libgloss did it manually and the way AM_ENABLE_MULTILIB does it) only rewrites "Makefile". We could try propagating the MULTI* variables from libgloss/Makefile down via FLAGS_TO_PASS, but this runs into a limitation: the multilib logic uses this variable to switch from libgloss/ to each multilib libgloss/, and libgloss uses this variable to enter subdirectories. The latter we want, but the former ends up overridding the Makefile environment. We could side-step that with some GNU Make directives, but it feels like we're getting a bit too deep down the rabbit hole. Instead, let's call config-ml.in ourselves for each subdir Makefile that the top-level configure generates. This restores the previous behavior and should be less risky in general. This logic should be unnecessary when/if we switch libgloss over to a non-recursive Automake build (since all build+install settings are in the single libgloss/Makefile), but it'll be a while before we can land that rework, so let's fix this up now.
Diffstat (limited to 'libgloss/arm')
-rwxr-xr-xlibgloss/arm/configure2
-rw-r--r--libgloss/arm/configure.ac4
2 files changed, 5 insertions, 1 deletions
diff --git a/libgloss/arm/configure b/libgloss/arm/configure
index 8e3866b56..84878afff 100755
--- a/libgloss/arm/configure
+++ b/libgloss/arm/configure
@@ -3926,6 +3926,8 @@ $as_echo X"$file" |
done
}
;;
+ "cpu-init/Makefile":F) ac_file=cpu-init/Makefile . ${srcdir}/../../config-ml.in
+ ;;
"default-1":C)
# Only add multilib support code if we just rebuilt the top-level
# Makefile.
diff --git a/libgloss/arm/configure.ac b/libgloss/arm/configure.ac
index 2b98b5453..3d7ba7da1 100644
--- a/libgloss/arm/configure.ac
+++ b/libgloss/arm/configure.ac
@@ -62,7 +62,9 @@ AC_SUBST_FILE(host_makefile_frag)
# Configure cpu init plug-ins
if test -d "${srcdir}/cpu-init"; then
subdirs="${subdirs} cpu-init"
- AC_CONFIG_FILES([cpu-init/Makefile])
+ AC_CONFIG_FILES([cpu-init/Makefile], [dnl
+ ac_file=cpu-init/Makefile . ${srcdir}/../../config-ml.in
+ ])
AC_SUBST(subdirs)
fi