diff options
| author | Mike Frysinger <vapier@gentoo.org> | 2022-01-21 07:45:23 +0300 |
|---|---|---|
| committer | Mike Frysinger <vapier@gentoo.org> | 2022-01-22 01:10:10 +0300 |
| commit | f159663b08f532eb77147abc6f8a65e4c5854773 (patch) | |
| tree | f01e896ad6f27bf1c2b67f75fb46f43e50605e78 /newlib/configure | |
| parent | 4317e0676a074a01be49ca8a51a4e1ab41ac4823 (diff) | |
newlib: stop clobbering LDFLAGS with non-standard $ldflags
It's unclear why this was added originally, but assuming it was needed
20 years ago, it shouldn't be explicitly required nowadays. Current
versions of autotools already take care of exporting LDFLAGS to the
Makefile as needed (things are actually getting linked). That's why
the configure diffs show LDFLAGS still here, but shifted to a diff
place in the output list. A few dirs stop exporting LDFLAGS, but
that's because they don't do any linking, only compiling, so it's
correct.
As for the use of $ldflags instead of the standard $LDFLAGS, I can't
really explain that at all. Just use the right name so users don't
have to dig into why their setting isn't respected, and then use a
non-standard name instead. Adjust the testsuite to match.
Diffstat (limited to 'newlib/configure')
| -rwxr-xr-x | newlib/configure | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/newlib/configure b/newlib/configure index 3837437f5..2aa297082 100755 --- a/newlib/configure +++ b/newlib/configure @@ -685,6 +685,7 @@ GREP EXEEXT ac_ct_CC CPPFLAGS +LDFLAGS CFLAGS LIBTOOL OBJDUMP @@ -710,7 +711,6 @@ ELIX_LEVEL_1_FALSE ELIX_LEVEL_1_TRUE ELIX_LEVEL_0_FALSE ELIX_LEVEL_0_TRUE -LDFLAGS NO_INCLUDE_LIST NEWLIB_CFLAGS CCASFLAGS @@ -4295,9 +4295,6 @@ NEWLIB_CFLAGS=${newlib_cflags} NO_INCLUDE_LIST=${noinclude} -LDFLAGS=${ldflags} - - if test x${newlib_elix_level} = x0; then ELIX_LEVEL_0_TRUE= ELIX_LEVEL_0_FALSE='#' @@ -12007,7 +12004,7 @@ else lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2 lt_status=$lt_dlunknown cat > conftest.$ac_ext <<_LT_EOF -#line 12010 "configure" +#line 12007 "configure" #include "confdefs.h" #if HAVE_DLFCN_H @@ -12113,7 +12110,7 @@ else lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2 lt_status=$lt_dlunknown cat > conftest.$ac_ext <<_LT_EOF -#line 12116 "configure" +#line 12113 "configure" #include "confdefs.h" #if HAVE_DLFCN_H |