diff options
| author | Corinna Vinschen <corinna@vinschen.de> | 2021-11-04 13:30:44 +0300 |
|---|---|---|
| committer | Corinna Vinschen <corinna@vinschen.de> | 2021-11-04 15:14:17 +0300 |
| commit | 4d90e5335914551862831de3e02f6c102b78435b (patch) | |
| tree | d434e5c50cd42752468f3da124f13c12e48cc67f /newlib/libc | |
| parent | d4e42ceb96b590f214b16442dc73f0c05db41e09 (diff) | |
ldtoa: fix dropping too many digits from output
ldtoa cuts the number of digits it returns based on a computation of
number of supported bits (144) divide by log10(2). Not only is the
integer approximation of log10(2) ~= 8/27 missing a digit here, it
also fails to take really small double and long double values into
account.
Allow for the full potential precision of long double values. At the
same time, change the local string array allocation to request only as
much bytes as necessary to support the caller-requested number of
digits, to keep the stack size low on small targets.
In the long run a better fix would be to switch to gdtoa, as the BSD
variants, as well as Mingw64 do.
Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
Diffstat (limited to 'newlib/libc')
| -rw-r--r-- | newlib/libc/stdlib/ldtoa.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/newlib/libc/stdlib/ldtoa.c b/newlib/libc/stdlib/ldtoa.c index 1cc97151a..7da61457b 100644 --- a/newlib/libc/stdlib/ldtoa.c +++ b/newlib/libc/stdlib/ldtoa.c @@ -34,9 +34,9 @@ void _IO_ldtostr (long double *, char *, int, int, char); #define NBITS ((NI-4)*16) /* Maximum number of decimal digits in ASCII conversion - * = NBITS*log10(2) + * Take full possible size of output into account */ -#define NDEC (NBITS*8/27) +#define NDEC 1023 /* The exponent of 1.0 */ #define EXONE (0x3fff) @@ -2794,7 +2794,6 @@ _ldtoa_r (struct _reent *ptr, long double d, int mode, int ndigits, LDPARMS rnd; LDPARMS *ldp = &rnd; char *outstr; - char outbuf[NDEC + MAX_EXP_DIGITS + 10]; union uconv du; du.d = d; @@ -2841,6 +2840,8 @@ _ldtoa_r (struct _reent *ptr, long double d, int mode, int ndigits, if (ndigits > NDEC) ndigits = NDEC; + char outbuf[ndigits + MAX_EXP_DIGITS + 10]; + etoasc (e, outbuf, ndigits, mode, ldp); s = outbuf; if (eisinf (e) || eisnan (e)) @@ -3111,6 +3112,8 @@ tnzro: else { emovi (y, w); + /* Note that this loop does not access the incoming string array, + * which may be shorter than NDEC + 1 bytes! */ for (i = 0; i < NDEC + 1; i++) { if ((w[NI - 1] & 0x7) != 0) |