diff options
| author | Mike Frysinger <vapier@gentoo.org> | 2022-01-21 07:45:23 +0300 |
|---|---|---|
| committer | Mike Frysinger <vapier@gentoo.org> | 2022-01-22 01:10:10 +0300 |
| commit | f159663b08f532eb77147abc6f8a65e4c5854773 (patch) | |
| tree | f01e896ad6f27bf1c2b67f75fb46f43e50605e78 /newlib/testsuite/lib | |
| parent | 4317e0676a074a01be49ca8a51a4e1ab41ac4823 (diff) | |
newlib: stop clobbering LDFLAGS with non-standard $ldflags
It's unclear why this was added originally, but assuming it was needed
20 years ago, it shouldn't be explicitly required nowadays. Current
versions of autotools already take care of exporting LDFLAGS to the
Makefile as needed (things are actually getting linked). That's why
the configure diffs show LDFLAGS still here, but shifted to a diff
place in the output list. A few dirs stop exporting LDFLAGS, but
that's because they don't do any linking, only compiling, so it's
correct.
As for the use of $ldflags instead of the standard $LDFLAGS, I can't
really explain that at all. Just use the right name so users don't
have to dig into why their setting isn't respected, and then use a
non-standard name instead. Adjust the testsuite to match.
Diffstat (limited to 'newlib/testsuite/lib')
| -rw-r--r-- | newlib/testsuite/lib/newlib.exp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/newlib/testsuite/lib/newlib.exp b/newlib/testsuite/lib/newlib.exp index f1df40e52..8b43d2e5d 100644 --- a/newlib/testsuite/lib/newlib.exp +++ b/newlib/testsuite/lib/newlib.exp @@ -66,13 +66,13 @@ proc newlib_target_compile { source dest type options } { [target_info needs_status_wrapper] != "0" && \ [info exists gluefile] } { lappend options "libs=$gluefile" - lappend options "ldflags=$wrap_flags" + lappend options "LDFLAGS=$wrap_flags" } if [string match $host_triplet $target_triplet] then { if [string match "i686-pc-linux-gnu" $host_triplet] then { lappend options "libs=$objdir/crt0.o -lc -lgcc" - lappend options "ldflags=-nostdlib -L$objdir/.libs [newlib_include_flags]" + lappend options "LDFLAGS=-nostdlib -L$objdir/.libs [newlib_include_flags]" } } |