* child_info.h (child_status): Fix typo which made it impossible to set

iscygwin.
(child_info::isstraced): Booleanize.
(child_info::iscygwin): Ditto.
* sigproc.cc (child_info::child_info): Minor cleanup of flag setting.
* spawn.cc (spawn_guts): Only close_all_files when we know the process has
started successfully.
* exceptions.cc (init_console_handler): Fix indentation.

1 files changed, 6 insertions, 6 deletions

diff --git a/winsup/cygwin/sigproc.cc b/winsup/cygwin/sigproc.cc
index 00a6cf90e..51c756934 100644
--- a/winsup/cygwin/sigproc.cc
+++ b/winsup/cygwin/sigproc.cc
@@ -780,16 +780,16 @@ child_info::child_info (unsigned in_cb, child_info_types chtype, bool need_subpr
   type = chtype;
   fhandler_union_cb = sizeof (fhandler_union);
   user_h = cygwin_user_h;
+  if (strace.attached ())
+    flag |= _CI_STRACED;
   if (need_subproc_ready)
-    subproc_ready = CreateEvent (&sec_all, FALSE, FALSE, NULL);
+    {
+      subproc_ready = CreateEvent (&sec_all, FALSE, FALSE, NULL);
+      flag |= _CI_ISCYGWIN;
+    }
   sigproc_printf ("subproc_ready %p", subproc_ready);
   cygheap = ::cygheap;
   cygheap_max = ::cygheap_max;
-  flag = 0;
-  if (strace.attached ())
-    flag |= _CI_STRACED;
-  if (need_subproc_ready)
-    flag |= _CI_ISCYGWIN;
   retry = child_info::retry_count;
   /* Create an inheritable handle to pass to the child process.  This will
      allow the child to duplicate handles from the parent to itself. */