diff options
| author | Jon Turney <jon.turney@dronecode.org.uk> | 2023-07-21 16:22:27 +0300 |
|---|---|---|
| committer | Jon Turney <jon.turney@dronecode.org.uk> | 2023-07-21 16:24:08 +0300 |
| commit | 8b0b719d499f6025b56652d8282d5a52f3722dc4 (patch) | |
| tree | b0c1864538abc73c93cf213eb6fae36e356cb471 /winsup/cygwin/syscalls.cc | |
| parent | 42b44044b34d7c26abf84f8b24f820e04e1662f2 (diff) | |
Cygwin: Fix uninitialized use of fh in strace output in stat_worker()
Move strace output to fix uninitalized use of fh introduced in previous commit.
../../../../src/winsup/cygwin/syscalls.cc: In function ‘int stat_worker(path_conv&, stat*)’:
../../../../src/winsup/cygwin/syscalls.cc:1971:69: error: ‘fh’ may be used uninitialized [-Werror=maybe-uninitialized]
Fixes: 42b44044b34d ("Cygwin: Fix Windows file handle leak in stat("file", -1)")
Signed-off-by: Jon Turney <jon.turney@dronecode.org.uk>
Diffstat (limited to 'winsup/cygwin/syscalls.cc')
| -rw-r--r-- | winsup/cygwin/syscalls.cc | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/winsup/cygwin/syscalls.cc b/winsup/cygwin/syscalls.cc index 32ace4d38..f1cd5693e 100644 --- a/winsup/cygwin/syscalls.cc +++ b/winsup/cygwin/syscalls.cc @@ -1967,13 +1967,14 @@ stat_worker (path_conv &pc, struct stat *buf) { fhandler_base *fh; - debug_printf ("(%S, %p, %p), file_attributes %d", - pc.get_nt_native_path (), buf, fh, (DWORD) *fh); memset (buf, 0, sizeof (*buf)); if (!(fh = build_fh_pc (pc))) __leave; + debug_printf ("(%S, %p, %p), file_attributes %d", + pc.get_nt_native_path (), buf, fh, (DWORD) *fh); + res = fh->fstat (buf); if (!res) fh->stat_fixup (buf); |