diff options
| author | Germano Cavalcante <germano.costa@ig.com.br> | 2022-03-01 22:11:38 +0300 |
|---|---|---|
| committer | Germano Cavalcante <germano.costa@ig.com.br> | 2022-03-01 22:30:30 +0300 |
| commit | 8e88af99348590e9879dcbfe97bbbc180fc5ec67 (patch) | |
| tree | 7617d5d1398c457752fd0185b9f1a243fbdd872e | |
| parent | 8322a4f6b76960cb4983f8aaf5a74e694aed1384 (diff) | |
Fix wrong object mode checking in snap code
The value of `OB_MODE_OBJECT` is 0, this makes it unsuitable as a bitflag.
Issue pointed out at https://pvs-studio.com/en/blog/posts/cpp/0922/
Thanks to Andrey Karpov
| -rw-r--r-- | source/blender/editors/transform/transform_snap_object.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/source/blender/editors/transform/transform_snap_object.c b/source/blender/editors/transform/transform_snap_object.c index dc9315b6d5a..515a4360bb5 100644 --- a/source/blender/editors/transform/transform_snap_object.c +++ b/source/blender/editors/transform/transform_snap_object.c @@ -491,7 +491,7 @@ static void iter_snap_objects(SnapObjectContext *sctx, } } else if (snap_select == SNAP_NOT_SELECTED) { - if (is_object_active && !(base->object->mode & OB_MODE_OBJECT)) { + if (is_object_active && base->object->mode != OB_MODE_OBJECT) { /* Pass. Consider the selection of elements being edited. */ } else if ((base->flag & BASE_SELECTED) || (base->flag_legacy & BA_WAS_SEL)) { |