Welcome to mirror list, hosted at ThFree Co, Russian Federation.

git.blender.org/blender.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSergey Sharybin <sergey.vfx@gmail.com>2016-10-24 15:04:31 +0300
committerSergey Sharybin <sergey.vfx@gmail.com>2016-10-24 15:05:55 +0300
commit21bf8639348bc75cd0c654f8ec5c3d110cf0ac5c (patch)
treee08c98bec22c0953920207cea5f7b35a6ca8b3b6
parent0b734f0b591a6e9406bbc177569a94bc88c8a810 (diff)
Cycles: Fix shadowing variable which also causes use of uninitialized variable
Was causing wrong aperture for panorama cameras. Seems to be a regression in 371d357.
-rw-r--r--intern/cycles/kernel/kernel_camera.h10
1 files changed, 5 insertions, 5 deletions
diff --git a/intern/cycles/kernel/kernel_camera.h b/intern/cycles/kernel/kernel_camera.h
index b99a82b0203..dedac6b1465 100644
--- a/intern/cycles/kernel/kernel_camera.h
+++ b/intern/cycles/kernel/kernel_camera.h
@@ -264,13 +264,13 @@ ccl_device_inline void camera_sample_panorama(KernelGlobals *kg,
float2 lensuv = camera_sample_aperture(kg, lens_u, lens_v)*aperturesize;
/* compute point on plane of focus */
- float3 D = normalize(D);
- float3 Pfocus = D * kernel_data.cam.focaldistance;
+ float3 Dfocus = normalize(D);
+ float3 Pfocus = Dfocus * kernel_data.cam.focaldistance;
- /* calculate orthonormal coordinates perpendicular to D */
+ /* calculate orthonormal coordinates perpendicular to Dfocus */
float3 U, V;
- U = normalize(make_float3(1.0f, 0.0f, 0.0f) - D.x * D);
- V = normalize(cross(D, U));
+ U = normalize(make_float3(1.0f, 0.0f, 0.0f) - Dfocus.x * Dfocus);
+ V = normalize(cross(Dfocus, U));
/* update ray for effect of lens */
P = U * lensuv.x + V * lensuv.y;