Welcome to mirror list, hosted at ThFree Co, Russian Federation.

git.blender.org/blender.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGermano Cavalcante <germano.costa@ig.com.br>2022-11-06 16:14:53 +0300
committerGermano Cavalcante <germano.costa@ig.com.br>2022-11-07 14:43:15 +0300
commit9ea82ce653c87ad96ecbc4ca01c59eb6a3280fd1 (patch)
tree001968f15f119492402f31adeb08e2ee912a6c10
parent7b845fb984ee9e593182594f7dd392a5c4efdcd7 (diff)
Fix potentially uninitialized memory usage
`nearest_world_tree_co` allows null parameter, so the `index` variable isn't really needed and doesn't even need to be initialized.
-rw-r--r--source/blender/editors/transform/transform_snap_object.cc7
1 files changed, 1 insertions, 6 deletions
diff --git a/source/blender/editors/transform/transform_snap_object.cc b/source/blender/editors/transform/transform_snap_object.cc
index a75a94803f7..2fab789afca 100644
--- a/source/blender/editors/transform/transform_snap_object.cc
+++ b/source/blender/editors/transform/transform_snap_object.cc
@@ -1187,14 +1187,13 @@ static bool nearest_world_tree(SnapObjectContext * /*sctx*/,
float co_local[3];
float no_local[3];
- int index;
copy_v3_v3(co_local, init_co_local);
for (int i = 0; i < params->face_nearest_steps; i++) {
add_v3_v3(co_local, delta_local);
nearest_world_tree_co(
- tree, nearest_cb, treedata, co_local, co_local, no_local, &index, nullptr);
+ tree, nearest_cb, treedata, co_local, co_local, no_local, r_index, nullptr);
}
mul_v3_m4v3(r_loc, obmat, co_local);
@@ -1204,10 +1203,6 @@ static bool nearest_world_tree(SnapObjectContext * /*sctx*/,
normalize_v3(r_no);
}
- if (r_index) {
- *r_index = index;
- }
-
return true;
}