Fix Workbench Memory Leak

Memory leaks happened when using final multi view rendering together with workbench.
Workbench assumed that the textures were always NULL

Reviewers: fclem

Differential Revision: https://developer.blender.org/D5136

1 files changed, 8 insertions, 2 deletions

diff --git a/source/blender/draw/engines/workbench/workbench_render.c b/source/blender/draw/engines/workbench/workbench_render.c
index 46d78ca0e37..b4e5e98c92b 100644
--- a/source/blender/draw/engines/workbench/workbench_render.c
+++ b/source/blender/draw/engines/workbench/workbench_render.c
@@ -82,8 +82,14 @@ static bool workbench_render_framebuffers_init(void)
   const int size[2] = {(int)viewport_size[0], (int)viewport_size[1]};
 
   DefaultTextureList *dtxl = DRW_viewport_texture_list_get();
-  dtxl->color = GPU_texture_create_2d(size[0], size[1], GPU_RGBA16F, NULL, NULL);
-  dtxl->depth = GPU_texture_create_2d(size[0], size[1], GPU_DEPTH24_STENCIL8, NULL, NULL);
+
+  /* When doing a multi view rendering the first view will allocate the buffers
+   * the other views will reuse these buffers */
+  if (dtxl->color == NULL) {
+    BLI_assert(dtxl->depth == NULL);
+    dtxl->color = GPU_texture_create_2d(size[0], size[1], GPU_RGBA16F, NULL, NULL);
+    dtxl->depth = GPU_texture_create_2d(size[0], size[1], GPU_DEPTH24_STENCIL8, NULL, NULL);
+  }
 
   if (!(dtxl->depth && dtxl->color)) {
     return false;