Welcome to mirror list, hosted at ThFree Co, Russian Federation.

git.blender.org/blender.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHans Goudey <h.goudey@me.com>2020-10-27 21:44:47 +0300
committerHans Goudey <h.goudey@me.com>2020-10-27 21:44:47 +0300
commit1504ed99e6dd90490b727a0b5114106ac816e85f (patch)
treec88e36420d3e62e35969d1e2de0ae6104c7c3992
parentc80594f57f1e5b73536f16e480a3bb459935848d (diff)
Fix use after free in interface handler
ASAN reported a use after free in after rB15d78ea85b602c. This commit removed a reassignment of the `data` variable here that was actually required because it may have been freed earlier in the function. This sort of error would be avoided if the same variable wasn't reused for different purposes.
-rw-r--r--source/blender/editors/interface/interface_handlers.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/source/blender/editors/interface/interface_handlers.c b/source/blender/editors/interface/interface_handlers.c
index b77f8bf3b63..4451199bb7c 100644
--- a/source/blender/editors/interface/interface_handlers.c
+++ b/source/blender/editors/interface/interface_handlers.c
@@ -7693,6 +7693,7 @@ static int ui_do_button(bContext *C, uiBlock *block, uiBut *but, const wmEvent *
}
#ifdef USE_DRAG_MULTINUM
+ data = but->active;
if (data) {
if (ELEM(event->type, MOUSEMOVE, INBETWEEN_MOUSEMOVE) ||
/* if we started dragging, progress on any event */