diff options
| author | Sergey Sharybin <sergey@blender.org> | 2021-03-15 17:16:10 +0300 |
|---|---|---|
| committer | Sergey Sharybin <sergey@blender.org> | 2021-03-15 17:55:09 +0300 |
| commit | 1f7140e70955b2fbbea7a2fc6307c471c95f243e (patch) | |
| tree | d6ab29ab6608ee3d7a2b82992307d4e1b040a115 | |
| parent | d8e1750e34726175c8bda9af7107bf8c1303a35f (diff) | |
Tracking: Mention TODO about DNA to Libmv API conversion
Current code works, but is heavily relying on matched enum definition
in the Blender's DNA and Libmv's API, which is suboptimal and fragile.
| -rw-r--r-- | source/blender/blenkernel/intern/tracking_region_tracker.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/source/blender/blenkernel/intern/tracking_region_tracker.c b/source/blender/blenkernel/intern/tracking_region_tracker.c index 7e37e438e24..68e866b355d 100644 --- a/source/blender/blenkernel/intern/tracking_region_tracker.c +++ b/source/blender/blenkernel/intern/tracking_region_tracker.c @@ -185,6 +185,8 @@ void tracking_configure_tracker(const MovieTrackingTrack *track, float *mask, libmv_TrackRegionOptions *options) { + /* TODO(sergey): Use explicit conversion, so that options are decoupled between the Libmv library + * and enumerator values in DNA. */ options->motion_model = track->motion_model; options->use_brute = ((track->algorithm_flag & TRACK_ALGORITHM_FLAG_USE_BRUTE) != 0); |