diff options
author | Campbell Barton <ideasman42@gmail.com> | 2013-04-25 13:39:03 +0400 |
---|---|---|
committer | Campbell Barton <ideasman42@gmail.com> | 2013-04-25 13:39:03 +0400 |
commit | a25703eb36c6d88d93e2d0645d413c339ce82d36 (patch) | |
tree | cf92024773423db01538b3cda2cc926526a3e2e8 | |
parent | 16f61b8b0b7c29aab69f359c2b0d172d960d425f (diff) |
ruler snap adjustments
- when in wireframe mode: don't snap to faces, instead snap to the closest edge/vertex.
- when not in wireframe mode: snap to the front-most element (was a problem that it could snap to an edge/vert behind the face)
- reduce the distance for selecting ruler points, was too easy to accidentally drag a ruler.
-rw-r--r-- | source/blender/editors/include/ED_transform.h | 3 | ||||
-rw-r--r-- | source/blender/editors/space_view3d/view3d_ruler.c | 48 | ||||
-rw-r--r-- | source/blender/editors/transform/transform_snap.c | 19 |
3 files changed, 50 insertions, 20 deletions
diff --git a/source/blender/editors/include/ED_transform.h b/source/blender/editors/include/ED_transform.h index dc4eb298998..256ff2d53ed 100644 --- a/source/blender/editors/include/ED_transform.h +++ b/source/blender/editors/include/ED_transform.h @@ -186,7 +186,8 @@ bool snapObjectsTransform(struct TransInfo *t, const float mval[2], float *r_dis bool snapObjectsContext(struct bContext *C, const float mval[2], float *r_dist_px, float r_loc[3], float r_no[3], SnapMode mode); /* taks args for all settings */ bool snapObjectsEx(struct Scene *scene, struct Base *base_act, struct View3D *v3d, struct ARegion *ar, struct Object *obedit, short snap_mode, - const float mval[2], float *r_dist_px, float r_loc[3], float r_no[3], SnapMode mode); + const float mval[2], float *r_dist_px, + float r_loc[3], float r_no[3], float *r_ray_dist, SnapMode mode); bool snapObjectsRayEx(struct Scene *scene, struct Base *base_act, struct View3D *v3d, struct ARegion *ar, struct Object *obedit, short snap_mode, struct Object **r_ob, float r_obmat[4][4], const float ray_start[3], const float ray_normal[3], float *r_ray_dist, diff --git a/source/blender/editors/space_view3d/view3d_ruler.c b/source/blender/editors/space_view3d/view3d_ruler.c index b38f4974f66..9e943c8af99 100644 --- a/source/blender/editors/space_view3d/view3d_ruler.c +++ b/source/blender/editors/space_view3d/view3d_ruler.c @@ -27,6 +27,7 @@ /* defines VIEW3D_OT_ruler modal operator */ #include "DNA_scene_types.h" +#include "DNA_object_types.h" #include "DNA_gpencil_types.h" #include "MEM_guardedalloc.h" @@ -60,11 +61,27 @@ /* NOTE - this is not very nice use of transform snapping */ #include "ED_transform.h" -static bool ED_view3d_snap_co(bContext *C, float r_co[3], const float co_ss[2], float r_no[3], +#define MVAL_MAX_PX_DIST 12.0f + +/** + * Convenience function for performing snapping. + * + * \param C Context. + * \param r_co hit location. + * \param r_no hit normal (optional). + * \param co_ss Screenspace coordinate. + * \param use_depth Snap to the closest element, use when using more then one snap type. + * \param use_vert Snap to verts. + * \param use_edge Snap to edges. + * \param use_face Snap to faces. + * \return Snap success + */ +static bool ED_view3d_snap_co(bContext *C, float r_co[3], float r_no[3], const float co_ss[2], bool use_depth, bool use_vert, bool use_edge, bool use_face) { - float dist_px = 12; /* snap dist */ + float dist_px = MVAL_MAX_PX_DIST; /* snap dist */ float r_no_dummy[3]; + float ray_dist = TRANSFORM_DIST_MAX_RAY; bool ret = false; float *r_no_ptr = r_no ? r_no : r_no_dummy; @@ -73,18 +90,22 @@ static bool ED_view3d_snap_co(bContext *C, float r_co[3], const float co_ss[2], ARegion *ar = CTX_wm_region(C); struct Object *obedit = CTX_data_edit_object(C); + BLI_assert(use_vert || use_edge || use_face); + /* try snap edge, then face if it fails */ if (use_vert) { ret = snapObjectsEx(scene, NULL, v3d, ar, obedit, SCE_SNAP_MODE_VERTEX, - co_ss, &dist_px, r_co, r_no_ptr, SNAP_ALL); + co_ss, &dist_px, r_co, r_no_ptr, &ray_dist, SNAP_ALL); } - if (use_edge && (ret == false)) { + if (use_edge && (ret == false || use_depth)) { + if (use_depth == false) ray_dist = TRANSFORM_DIST_MAX_RAY; ret = snapObjectsEx(scene, NULL, v3d, ar, obedit, SCE_SNAP_MODE_EDGE, - co_ss, &dist_px, r_co, r_no_ptr, SNAP_ALL); + co_ss, &dist_px, r_co, r_no_ptr, &ray_dist, SNAP_ALL); } - if (use_face && (ret == false)) { + if (use_face && (ret == false || use_depth)) { + if (use_depth == false) ray_dist = TRANSFORM_DIST_MAX_RAY; ret = snapObjectsEx(scene, NULL, v3d, ar, obedit, SCE_SNAP_MODE_FACE, - co_ss, &dist_px, r_co, r_no_ptr, SNAP_ALL); + co_ss, &dist_px, r_co, r_no_ptr, &ray_dist, SNAP_ALL); } return ret; @@ -93,7 +114,7 @@ static bool ED_view3d_snap_co(bContext *C, float r_co[3], const float co_ss[2], static bool ED_view3d_snap_ray(bContext *C, float r_co[3], const float ray_start[3], const float ray_normal[3]) { - float dist_px = 12; /* snap dist */ + float dist_px = MVAL_MAX_PX_DIST; /* snap dist */ float r_no_dummy[3]; float ray_dist = TRANSFORM_DIST_MAX_RAY; bool ret; @@ -126,7 +147,8 @@ enum { RULERITEM_DIRECTION_OUT }; -#define RULER_PICK_DIST 75.0f +/* keep smaller then selection, since we may want click elsewhere without selecting a ruler */ +#define RULER_PICK_DIST 12.0f #define RULER_PICK_DIST_SQ (RULER_PICK_DIST * RULER_PICK_DIST) typedef struct RulerItem { @@ -690,7 +712,7 @@ static bool view3d_ruler_item_mousemove(bContext *C, RulerInfo *ruler_info, cons co_other = ruler_item->co[ruler_item->co_index == 0 ? 2 : 0]; - if (ED_view3d_snap_co(C, co, mval_fl, ray_normal, + if (ED_view3d_snap_co(C, co, ray_normal, mval_fl, true, false, false, true)) { negate_v3(ray_normal); @@ -702,8 +724,10 @@ static bool view3d_ruler_item_mousemove(bContext *C, RulerInfo *ruler_info, cons } else if (do_snap) { const float mval_fl[2] = {UNPACK2(mval)}; - ED_view3d_snap_co(C, co, mval_fl, NULL, - true, true, true); + View3D *v3d = CTX_wm_view3d(C); + bool use_depth = (v3d->drawtype >= OB_SOLID); + ED_view3d_snap_co(C, co, NULL, mval_fl, use_depth, + true, true, use_depth); } return true; } diff --git a/source/blender/editors/transform/transform_snap.c b/source/blender/editors/transform/transform_snap.c index bb2ba2b6e3b..6b529e13aec 100644 --- a/source/blender/editors/transform/transform_snap.c +++ b/source/blender/editors/transform/transform_snap.c @@ -1615,10 +1615,10 @@ static bool snapObjectsRay(Scene *scene, short snap_mode, Base *base_act, View3D return retval; } static bool snapObjects(Scene *scene, short snap_mode, Base *base_act, View3D *v3d, ARegion *ar, Object *obedit, - const float mval[2], float *r_dist_px, float r_loc[3], float r_no[3], SnapMode mode) + const float mval[2], float *r_dist_px, + float r_loc[3], float r_no[3], float *r_ray_dist, SnapMode mode) { float ray_start[3], ray_normal[3]; - float ray_dist = TRANSFORM_DIST_MAX_RAY; if (ED_view3d_win_to_ray(ar, v3d, mval, ray_start, ray_normal, true) == false) { return false; @@ -1626,14 +1626,15 @@ static bool snapObjects(Scene *scene, short snap_mode, Base *base_act, View3D *v return snapObjectsRay(scene, snap_mode, base_act, v3d, ar, obedit, NULL, NULL, - ray_start, ray_normal, &ray_dist, + ray_start, ray_normal, r_ray_dist, mval, r_dist_px, r_loc, r_no, mode); } bool snapObjectsTransform(TransInfo *t, const float mval[2], float *r_dist_px, float r_loc[3], float r_no[3], SnapMode mode) { + float ray_dist = TRANSFORM_DIST_MAX_RAY; return snapObjects(t->scene, t->scene->toolsettings->snap_mode, t->scene->basact, t->view, t->ar, t->obedit, - mval, r_dist_px, r_loc, r_no, mode); + mval, r_dist_px, r_loc, r_no, &ray_dist, mode); } bool snapObjectsContext(bContext *C, const float mval[2], float *r_dist_px, float r_loc[3], float r_no[3], SnapMode mode) @@ -1643,15 +1644,19 @@ bool snapObjectsContext(bContext *C, const float mval[2], float *r_dist_px, floa Scene *scene = CTX_data_scene(C); ARegion *ar = CTX_wm_region(C); Object *obedit = CTX_data_edit_object(C); + float ray_dist = TRANSFORM_DIST_MAX_RAY; - return snapObjects(scene, scene->toolsettings->snap_mode, scene->basact, v3d, ar, obedit, mval, r_dist_px, r_loc, r_no, mode); + return snapObjects(scene, scene->toolsettings->snap_mode, scene->basact, v3d, ar, obedit, + mval, r_dist_px, r_loc, r_no, &ray_dist, mode); } bool snapObjectsEx(Scene *scene, Base *base_act, View3D *v3d, ARegion *ar, Object *obedit, short snap_mode, - const float mval[2], float *r_dist_px, float r_loc[3], float r_no[3], SnapMode mode) + const float mval[2], float *r_dist_px, + float r_loc[3], float r_no[3], float *r_ray_dist, SnapMode mode) { return snapObjects(scene, snap_mode, base_act, v3d, ar, obedit, - mval, r_dist_px, r_loc, r_no, mode); + mval, r_dist_px, + r_loc, r_no, r_ray_dist, mode); } bool snapObjectsRayEx(Scene *scene, Base *base_act, View3D *v3d, ARegion *ar, Object *obedit, short snap_mode, Object **r_ob, float r_obmat[4][4], |