diff options
author | Jacques Lucke <jacques@blender.org> | 2020-07-03 17:38:01 +0300 |
---|---|---|
committer | Jacques Lucke <jacques@blender.org> | 2020-07-03 17:39:06 +0300 |
commit | 14fd91e7e82a97e8f629bb86d6df50a6336d28f5 (patch) | |
tree | e79037a18e3efdc541f352e477c5125b22db1c58 | |
parent | f4fdb8efc5806524740e91d9f44283057d27ec46 (diff) |
Clang-Tidy: enable bugprone-argument-comment
It was called `inverted` in the header.
-rw-r--r-- | .clang-tidy | 1 | ||||
-rw-r--r-- | source/blender/io/collada/BCMath.cpp | 23 |
2 files changed, 13 insertions, 11 deletions
diff --git a/.clang-tidy b/.clang-tidy index d1287ff7875..71095e3c59c 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -41,7 +41,6 @@ Checks: > -bugprone-misplaced-widening-cast, -bugprone-not-null-terminated-result, -bugprone-suspicious-missing-comma, - -bugprone-argument-comment, -bugprone-assert-side-effect, -bugprone-parent-virtual-call, -bugprone-infinite-loop, diff --git a/source/blender/io/collada/BCMath.cpp b/source/blender/io/collada/BCMath.cpp index e8765fa2bcd..a03e2ad6488 100644 --- a/source/blender/io/collada/BCMath.cpp +++ b/source/blender/io/collada/BCMath.cpp @@ -72,27 +72,30 @@ BCMatrix::BCMatrix(BC_global_forward_axis global_forward_axis, BC_global_up_axis set_transform(mat); } -void BCMatrix::add_transform(const Matrix &mat, bool inverse) +void BCMatrix::add_transform(const Matrix &mat, bool inverted) { - add_transform(this->matrix, mat, this->matrix, inverse); + add_transform(this->matrix, mat, this->matrix, inverted); } -void BCMatrix::add_transform(const BCMatrix &mat, bool inverse) +void BCMatrix::add_transform(const BCMatrix &mat, bool inverted) { - add_transform(this->matrix, mat.matrix, this->matrix, inverse); + add_transform(this->matrix, mat.matrix, this->matrix, inverted); } -void BCMatrix::apply_transform(const BCMatrix &mat, bool inverse) +void BCMatrix::apply_transform(const BCMatrix &mat, bool inverted) { - apply_transform(this->matrix, mat.matrix, this->matrix, inverse); + apply_transform(this->matrix, mat.matrix, this->matrix, inverted); } -void BCMatrix::add_transform(Matrix &to, const Matrix &transform, const Matrix &from, bool inverse) +void BCMatrix::add_transform(Matrix &to, + const Matrix &transform, + const Matrix &from, + bool inverted) { - if (inverse) { + if (inverted) { Matrix globinv; invert_m4_m4(globinv, transform); - add_transform(to, globinv, from, /*inverse=*/false); + add_transform(to, globinv, from, /*inverted=*/false); } else { mul_m4_m4m4(to, transform, from); @@ -107,7 +110,7 @@ void BCMatrix::apply_transform(Matrix &to, Matrix globinv; invert_m4_m4(globinv, transform); if (inverse) { - add_transform(to, globinv, from, /*inverse=*/false); + add_transform(to, globinv, from, /*inverted=*/false); } else { mul_m4_m4m4(to, transform, from); |