diff options
author | Sergey Sharybin <sergey.vfx@gmail.com> | 2014-08-27 12:48:35 +0400 |
---|---|---|
committer | Sergey Sharybin <sergey.vfx@gmail.com> | 2014-08-27 12:49:47 +0400 |
commit | 9b9ddb46697b56213cb1e968ac0c8ddefc5ee79e (patch) | |
tree | f1f722583633221ce99cb31a1c90cfd4ad9c3fa8 | |
parent | e40d8258bb46926a1aecf51236822532397993f3 (diff) |
Make SCons's DEBUG/_DEBUG consistent with CMake
Also move this to a generic place in SConstruct instead of having this
defines in 6 different configurations.
Should not be functional changes, but please verify all the platforms.
-rw-r--r-- | SConstruct | 5 | ||||
-rw-r--r-- | build_files/scons/config/darwin-config.py | 4 | ||||
-rw-r--r-- | build_files/scons/config/linux-config.py | 4 | ||||
-rw-r--r-- | build_files/scons/config/win32-mingw-config.py | 4 | ||||
-rw-r--r-- | build_files/scons/config/win32-vc-config.py | 2 | ||||
-rw-r--r-- | build_files/scons/config/win64-mingw-config.py | 4 | ||||
-rw-r--r-- | build_files/scons/config/win64-vc-config.py | 2 |
7 files changed, 15 insertions, 10 deletions
diff --git a/SConstruct b/SConstruct index 7263a5ddfa1..0c398f87256 100644 --- a/SConstruct +++ b/SConstruct @@ -210,6 +210,11 @@ if sys.platform=='win32': if B.bitness==64: env.Append(CPPFLAGS=['-DWIN64']) # -DWIN32 needed too, as it's used all over to target Windows generally +if env['BF_DEBUG']: + env.Append(CPPDEFINES=['_DEBUG', 'DEBUG']) +else: + env.Append(CPPDEFINES=['NDEBUG']) + if not env['BF_FANCY']: B.bc.disable() diff --git a/build_files/scons/config/darwin-config.py b/build_files/scons/config/darwin-config.py index 7bb4c266ee5..338065e5e88 100644 --- a/build_files/scons/config/darwin-config.py +++ b/build_files/scons/config/darwin-config.py @@ -237,7 +237,7 @@ LLIBS = ['stdc++'] REL_CFLAGS = [] REL_CXXFLAGS = [] -REL_CCFLAGS = ['-DNDEBUG', '-O2'] +REL_CCFLAGS = ['-O2'] CC_WARN = ['-Wall'] C_WARN = ['-Wno-char-subscripts', '-Wpointer-arith', '-Wcast-align', '-Wdeclaration-after-statement', '-Wno-unknown-pragmas', '-Wstrict-prototypes'] @@ -253,7 +253,7 @@ BF_PROFILE_LINKFLAGS = ['-pg'] BF_PROFILE = False BF_DEBUG = False -BF_DEBUG_CCFLAGS = ['-g', '-D_DEBUG'] +BF_DEBUG_CCFLAGS = ['-g'] ############################################################################# ################### Output directories ################## diff --git a/build_files/scons/config/linux-config.py b/build_files/scons/config/linux-config.py index 0c76aecfc4b..05f09c2f2da 100644 --- a/build_files/scons/config/linux-config.py +++ b/build_files/scons/config/linux-config.py @@ -241,7 +241,7 @@ if WITH_BF_FFMPEG: CXXFLAGS += ['-D__STDC_CONSTANT_MACROS', ] REL_CFLAGS = [] REL_CXXFLAGS = [] -REL_CCFLAGS = ['-DNDEBUG', '-O2'] +REL_CCFLAGS = ['-O2'] C_WARN = ['-Wno-char-subscripts', '-Wdeclaration-after-statement', '-Wunused-parameter', '-Wstrict-prototypes', '-Werror=declaration-after-statement', '-Werror=implicit-function-declaration', '-Werror=return-type'] CC_WARN = ['-Wall'] @@ -254,7 +254,7 @@ BF_PROFILE_CCFLAGS = ['-pg','-g'] BF_PROFILE_LINKFLAGS = ['-pg'] BF_DEBUG = False -BF_DEBUG_CCFLAGS = ['-g', '-D_DEBUG'] +BF_DEBUG_CCFLAGS = ['-g'] BF_BUILDDIR = '../build/linux' BF_INSTALLDIR='../install/linux' diff --git a/build_files/scons/config/win32-mingw-config.py b/build_files/scons/config/win32-mingw-config.py index a6d1a7d7996..85aa72af19c 100644 --- a/build_files/scons/config/win32-mingw-config.py +++ b/build_files/scons/config/win32-mingw-config.py @@ -190,7 +190,7 @@ CXXFLAGS = [] CPPFLAGS = ['-DWIN32', '-DFREE_WINDOWS', '-D_LARGEFILE_SOURCE', '-D_FILE_OFFSET_BITS=64', '-D_LARGEFILE64_SOURCE', '-DBOOST_ALL_NO_LIB', '-DBOOST_THREAD_USE_LIB', '-DGLEW_STATIC', '-DOPJ_STATIC'] REL_CFLAGS = [] REL_CXXFLAGS = [] -REL_CCFLAGS = ['-DNDEBUG', '-O2'] +REL_CCFLAGS = ['-O2'] C_WARN = ['-Wno-char-subscripts', '-Wdeclaration-after-statement', '-Wstrict-prototypes'] @@ -205,7 +205,7 @@ PLATFORM_LINKFLAGS = ['-Xlinker', '--stack=2097152'] # PLATFORM_LINKFLAGS += ["-static-libgcc", "-static-libstdc++"] BF_DEBUG = False -BF_DEBUG_CCFLAGS= ['-g', '-D_DEBUG'] +BF_DEBUG_CCFLAGS= ['-g'] BF_PROFILE_CCFLAGS = ['-pg', '-g'] BF_PROFILE_LINKFLAGS = ['-pg'] diff --git a/build_files/scons/config/win32-vc-config.py b/build_files/scons/config/win32-vc-config.py index 0d08a3dffab..6dd853b7da4 100644 --- a/build_files/scons/config/win32-vc-config.py +++ b/build_files/scons/config/win32-vc-config.py @@ -229,7 +229,7 @@ BF_DEBUG_CCFLAGS = ['/Zi', '/Ob0', '/Od', '/FR${TARGET}.sbr'] CPPFLAGS = ['-DWIN32','-D_CONSOLE', '-D_LIB', '-D_CRT_SECURE_NO_DEPRECATE', '-DOPJ_STATIC'] REL_CFLAGS = [] REL_CXXFLAGS = [] -REL_CCFLAGS = ['-O2', '/Ob2', '-DNDEBUG'] +REL_CCFLAGS = ['-O2', '/Ob2'] C_WARN = [] CC_WARN = [] diff --git a/build_files/scons/config/win64-mingw-config.py b/build_files/scons/config/win64-mingw-config.py index dcdea6583d7..92dcd6db455 100644 --- a/build_files/scons/config/win64-mingw-config.py +++ b/build_files/scons/config/win64-mingw-config.py @@ -184,7 +184,7 @@ CXXFLAGS = [ '-fpermissive' ] CPPFLAGS = ['-DWIN32', '-DMS_WIN64', '-DFREE_WINDOWS', '-DFREE_WINDOWS64', '-D_LARGEFILE_SOURCE', '-D_FILE_OFFSET_BITS=64', '-D_LARGEFILE64_SOURCE', '-DBOOST_ALL_NO_LIB', '-DBOOST_THREAD_USE_LIB', '-DGLEW_STATIC', '-DOPJ_STATIC'] REL_CFLAGS = [] REL_CXXFLAGS = [] -REL_CCFLAGS = ['-DNDEBUG', '-O2', '-ftree-vectorize'] +REL_CCFLAGS = ['-O2', '-ftree-vectorize'] C_WARN = ['-Wno-char-subscripts', '-Wdeclaration-after-statement', '-Wstrict-prototypes'] @@ -199,7 +199,7 @@ PLATFORM_LINKFLAGS = ['-Xlinker', '--stack=2097152'] # PLATFORM_LINKFLAGS += ["-static-libgcc", "-static-libstdc++"] BF_DEBUG = False -BF_DEBUG_CCFLAGS= ['-g', '-D_DEBUG'] +BF_DEBUG_CCFLAGS= ['-g'] BF_PROFILE_CCFLAGS = ['-pg', '-g'] BF_PROFILE_LINKFLAGS = ['-pg'] diff --git a/build_files/scons/config/win64-vc-config.py b/build_files/scons/config/win64-vc-config.py index 3e79c68a2ba..f928f166ba7 100644 --- a/build_files/scons/config/win64-vc-config.py +++ b/build_files/scons/config/win64-vc-config.py @@ -236,7 +236,7 @@ BF_DEBUG_CCFLAGS = ['/Zi', '/FR${TARGET}.sbr', '/Od', '/Ob0'] CPPFLAGS = ['-DWIN32', '-D_CONSOLE', '-D_LIB', '-D_CRT_SECURE_NO_DEPRECATE', '-DOPJ_STATIC'] REL_CFLAGS = [] REL_CXXFLAGS = [] -REL_CCFLAGS = ['-O2', '/Ob2', '-DNDEBUG'] +REL_CCFLAGS = ['-O2', '/Ob2'] C_WARN = [] CC_WARN = [] |