Welcome to mirror list, hosted at ThFree Co, Russian Federation.

git.blender.org/blender.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJacques Lucke <jacques@blender.org>2021-11-02 14:26:42 +0300
committerJacques Lucke <jacques@blender.org>2021-11-02 14:30:27 +0300
commitb1bf8848895bf4b35a14f89806f1f5807198e321 (patch)
tree5777bfa57ced9a3b06fe7d98f1edecbdb332681d
parent9bd97e62ade417f6b4025acbad46802c3e7e5683 (diff)
Images: fix error in previous refactor
Some compositor tests (e.g. `compositor_color_test`) broke because of rB0c3b215e7d5456878b155d13440864f49ad1f230. The issue was a heap-use-after-free bug caused by a missing call to `MEM_CacheLimiter_unmanage`.
-rw-r--r--source/blender/imbuf/intern/moviecache.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/source/blender/imbuf/intern/moviecache.c b/source/blender/imbuf/intern/moviecache.c
index 8d0f55f5007..6e7b85a300a 100644
--- a/source/blender/imbuf/intern/moviecache.c
+++ b/source/blender/imbuf/intern/moviecache.c
@@ -122,8 +122,8 @@ static void moviecache_valfree(void *val)
PRINT("%s: cache '%s' free item %p buffer %p\n", __func__, cache->name, item, item->ibuf);
+ MEM_CacheLimiter_unmanage(item->c_handle);
if (item->ibuf) {
- MEM_CacheLimiter_unmanage(item->c_handle);
IMB_freeImBuf(item->ibuf);
}