diff options
| author | Ray Molenkamp <github@lazydodo.com> | 2020-06-17 18:26:49 +0300 |
|---|---|---|
| committer | Jeroen Bakker <jeroen@blender.org> | 2020-06-25 10:32:04 +0300 |
| commit | 945e18f037108c2767617ddba339e0f7938329d8 (patch) | |
| tree | bd93ef32411b6be48e0b35b9c8a2d0de49d538b4 | |
| parent | 293b00beb5df27b4455de743fd0684f0988153b0 (diff) | |
Fix T76767: Cycles performance regression with CLI renders
When picking a small tile size when doing a CLI render will
yield many status updates being printed to the console
causing a slowdown in the render process. 2.79 with the
same amount of tiles did not have this slowdown.
The reason for this turned out to be a debugging aid added
in rBd2757d149bf2 which disabled buffering for stdout which
on windows caused every single character being printed to the
console to try to obtain a mutex, and worse the thread being
put to sleep when this mutex was unavailable leading to poor
performance.
This patch changes the behaviour by only disabling the
buffering in debug builds.
CLI render of the default cube with 16x16 tiles at 1080p
2.83 : 37.57s
now : 17.03s
note: this only affected CLI renders, renders from the UI
do not report this kind of information and had no such
slowdown.
| -rw-r--r-- | source/creator/creator.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/source/creator/creator.c b/source/creator/creator.c index 6c4af7be95e..38a03867a57 100644 --- a/source/creator/creator.c +++ b/source/creator/creator.c @@ -247,8 +247,12 @@ int main(int argc, /* Unbuffered stdout makes stdout and stderr better synchronized, and helps * when stepping through code in a debugger (prints are immediately - * visible). */ + * visible). However disabling buffering causes lock contention on windows + * see T76767 for detais, since this is a debugging aid, we do not enable + * the unbuffered behavior for release builds. */ +#ifndef NDEBUG setvbuf(stdout, NULL, _IONBF, 0); +#endif #ifdef WIN32 /* We delay loading of openmp so we can set the policy here. */ |