diff options
author | Brecht Van Lommel <brechtvanlommel@gmail.com> | 2019-07-11 15:13:22 +0300 |
---|---|---|
committer | Brecht Van Lommel <brechtvanlommel@gmail.com> | 2019-07-11 16:03:13 +0300 |
commit | f0b72a776ed888da798b41ce43995f7b5ac11ec0 (patch) | |
tree | 6d59ea7855efd05233ed177a97fa9870ad1cdf39 | |
parent | 8a1552545a6274d2ff201e0f98067199cbd47cc2 (diff) |
Fix T66706: crash in viewport shading popover for workbench engine
Differential Revision: https://developer.blender.org/D5226
-rw-r--r-- | source/blender/makesrna/intern/rna_space.c | 11 |
1 files changed, 4 insertions, 7 deletions
diff --git a/source/blender/makesrna/intern/rna_space.c b/source/blender/makesrna/intern/rna_space.c index 1c76753fb1b..2ba5e2ae68c 100644 --- a/source/blender/makesrna/intern/rna_space.c +++ b/source/blender/makesrna/intern/rna_space.c @@ -1067,11 +1067,7 @@ static const EnumPropertyItem *rna_View3DShading_color_type_itemf(bContext *UNUS int totitem = 0; - if (shading->type == OB_SOLID) { - r_free = false; - return rna_enum_shading_color_type_items; - } - else if (shading->type == OB_WIRE) { + if (shading->type == OB_WIRE) { EnumPropertyItem *item = NULL; RNA_enum_items_add_value( &item, &totitem, rna_enum_shading_color_type_items, V3D_SHADING_SINGLE_COLOR); @@ -1084,8 +1080,9 @@ static const EnumPropertyItem *rna_View3DShading_color_type_itemf(bContext *UNUS return item; } else { - *r_free = false; - return NULL; + /* Solid mode, or lookdev mode for workbench engine. */ + r_free = false; + return rna_enum_shading_color_type_items; } } |