diff options
| author | Brecht Van Lommel <brechtvanlommel@gmail.com> | 2018-01-26 09:54:09 +0300 |
|---|---|---|
| committer | Brecht Van Lommel <brechtvanlommel@gmail.com> | 2018-01-26 10:45:37 +0300 |
| commit | 0e37c98257ca66d88bc17b301c4569fc7de66712 (patch) | |
| tree | 04b2976b896b737d9984c94627dcd918bf6652c9 | |
| parent | 4c1bed0a1225857d2bcdbcfc65cb7bf774cd2abb (diff) | |
Fix part of T53080: all material previews re-rendering after undo.
This reverts commit dc2617130b2e1d7d2b9892fbd7c6e7b60caafb66, which disabled
writing of previews for undo. While this uses some memory, re-rendering all
previews is very expensive, especially if for example you have lots of materials
using high-res image textures.
| -rw-r--r-- | source/blender/blenloader/intern/writefile.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/source/blender/blenloader/intern/writefile.c b/source/blender/blenloader/intern/writefile.c index ee9665dc834..a50afc42245 100644 --- a/source/blender/blenloader/intern/writefile.c +++ b/source/blender/blenloader/intern/writefile.c @@ -679,8 +679,10 @@ static void write_iddata(void *wd, const ID *id) static void write_previews(WriteData *wd, const PreviewImage *prv_orig) { - /* Never write previews when doing memsave (i.e. undo/redo)! */ - if (prv_orig && !wd->current) { + /* Note we write previews also for undo steps. It takes up some memory, + * but not doing so would causes all previews to be re-rendered after + * undo which is too expensive. */ + if (prv_orig) { PreviewImage prv = *prv_orig; /* don't write out large previews if not requested */ |