diff options
author | Brecht Van Lommel <brecht@blender.org> | 2021-12-08 17:40:09 +0300 |
---|---|---|
committer | Brecht Van Lommel <brecht@blender.org> | 2021-12-08 17:44:23 +0300 |
commit | 39ebb8be4d5916a71e012ac339b029641b31f10b (patch) | |
tree | 1951e63c4ba27a25175b7cac7fd3effc13058d79 | |
parent | fb762eedbe85515b6f61138f32e36eddaab24960 (diff) |
Fix T91680: viewport selection broken in macOS x86 build with Xcode 13
There is an apparent compiler bug here, tweak the code to avoid it. This did
not affect official builds as we were still using Xcode 12.
-rw-r--r-- | source/blender/editors/space_view3d/view3d_view.c | 34 |
1 files changed, 21 insertions, 13 deletions
diff --git a/source/blender/editors/space_view3d/view3d_view.c b/source/blender/editors/space_view3d/view3d_view.c index 21cb8560e9b..2935d98c036 100644 --- a/source/blender/editors/space_view3d/view3d_view.c +++ b/source/blender/editors/space_view3d/view3d_view.c @@ -719,12 +719,12 @@ void view3d_winmatrix_set(Depsgraph *depsgraph, const rcti *rect) { RegionView3D *rv3d = region->regiondata; - rctf viewplane; + rctf full_viewplane; float clipsta, clipend; bool is_ortho; is_ortho = ED_view3d_viewplane_get( - depsgraph, v3d, rv3d, region->winx, region->winy, &viewplane, &clipsta, &clipend, NULL); + depsgraph, v3d, rv3d, region->winx, region->winy, &full_viewplane, &clipsta, &clipend, NULL); rv3d->is_persp = !is_ortho; #if 0 @@ -732,21 +732,29 @@ void view3d_winmatrix_set(Depsgraph *depsgraph, __func__, winx, winy, - viewplane.xmin, - viewplane.ymin, - viewplane.xmax, - viewplane.ymax, + full_viewplane.xmin, + full_viewplane.ymin, + full_viewplane.xmax, + full_viewplane.ymax, clipsta, clipend); #endif - if (rect) { /* picking */ - rctf r; - r.xmin = viewplane.xmin + (BLI_rctf_size_x(&viewplane) * (rect->xmin / (float)region->winx)); - r.ymin = viewplane.ymin + (BLI_rctf_size_y(&viewplane) * (rect->ymin / (float)region->winy)); - r.xmax = viewplane.xmin + (BLI_rctf_size_x(&viewplane) * (rect->xmax / (float)region->winx)); - r.ymax = viewplane.ymin + (BLI_rctf_size_y(&viewplane) * (rect->ymax / (float)region->winy)); - viewplane = r; + /* Note the code here was tweaked to avoid an apparent compiler bug in clang 13 (see T91680). */ + rctf viewplane; + if (rect) { + /* Smaller viewplane subset for selection picking. */ + viewplane.xmin = full_viewplane.xmin + + (BLI_rctf_size_x(&full_viewplane) * (rect->xmin / (float)region->winx)); + viewplane.ymin = full_viewplane.ymin + + (BLI_rctf_size_y(&full_viewplane) * (rect->ymin / (float)region->winy)); + viewplane.xmax = full_viewplane.xmin + + (BLI_rctf_size_x(&full_viewplane) * (rect->xmax / (float)region->winx)); + viewplane.ymax = full_viewplane.ymin + + (BLI_rctf_size_y(&full_viewplane) * (rect->ymax / (float)region->winy)); + } + else { + viewplane = full_viewplane; } if (is_ortho) { |