diff options
| author | Sergey Sharybin <sergey.vfx@gmail.com> | 2016-04-22 11:59:15 +0300 |
|---|---|---|
| committer | Sergey Sharybin <sergey.vfx@gmail.com> | 2016-04-22 11:59:15 +0300 |
| commit | 87dcee0c0c33ab2f2a8d22e0d0b53f0289ef7a46 (patch) | |
| tree | 9a1558bcb4e624fd1706be9dc460bd5fb0ba50b6 /build_files | |
| parent | d2cb0f955b25857cb4f3fd28ebc4567f997d56b2 (diff) | |
Silence some annoying warnings when doing full build with strict flags
This mainly touches extern libraries and few debug-only places in intern.
Some summary:
- External libraries are not strict at all about missing declarations,
so we can rather safely remove such warning together with other strict
flags.
- Bullet has some static functions which are not used.
Those were commented out.
- Carve now has some unused debug-only functions commented out as well.
While we're on the way of getting rid of Carve, it makes sense to make
things a bit cleaner for the time being.
- In LZMA we have some parts disabled which gives some set but unused
variables which is rather correct.
- Elbeem had quite some variables set and never used because their usage
is inside of debug-only code which is commented out.
Note about patching upstream libraries: surely one might say that we
have to make local patchset against this, but own experience says it
only gives extra work trying to merge such tweaks to a new upstream
version and usually it's just faster to re-apply such fixes again after
bundling new upstream library.
Diffstat (limited to 'build_files')
| -rw-r--r-- | build_files/cmake/macros.cmake | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/build_files/cmake/macros.cmake b/build_files/cmake/macros.cmake index 85bc4008346..f26b22a9c5f 100644 --- a/build_files/cmake/macros.cmake +++ b/build_files/cmake/macros.cmake @@ -968,6 +968,7 @@ macro(remove_strict_flags) remove_cc_flag( "-Wstrict-prototypes" "-Wmissing-prototypes" + "-Wmissing-declarations" "-Wmissing-format-attribute" "-Wunused-local-typedefs" "-Wunused-macros" |