diff options
author | Ray Molenkamp <github@lazydodo.com> | 2020-02-14 03:13:07 +0300 |
---|---|---|
committer | Ray Molenkamp <github@lazydodo.com> | 2020-02-14 03:13:07 +0300 |
commit | 75a5ea01c19563ae1ba427e9206f2eae637d6070 (patch) | |
tree | c611b4c77aaec2414dd2ca2f42dc539f4e57916a /extern/mantaflow/CMakeLists.txt | |
parent | 4af74f453d4e41129626f7578c55ac9927f6d02a (diff) |
Cleanup/MSVC: Enable C++ conformance mode on compiler versions that support it.
MSVC has a conformance mode (/permissive-) where the C++ standard is more strictly
enforced. This mode is available on MSVC 15.5+ [1]
This patch enables this mode on compilers that support it and cleans up the few violations it threw up in the process.
- Mantaflow was using M_PI without requesting them using the _USE_MATH_DEFINES define to opt in to non default behaviour.
- Collada did not include the right header for std::cerr, this seemingly was fixed for other platforms already but put inside a platform guard.
- Ghost had some scoping issues regarding uninitialized variables and goto behaviour
Second landing of this patch, earlier commit was reverted due to some compiler configurations having slipped though testing
[1] https://docs.microsoft.com/en-us/cpp/build/reference/permissive-standards-conformance
Differential Revision: https://developer.blender.org/D6824
Reviewed By: brecht
Diffstat (limited to 'extern/mantaflow/CMakeLists.txt')
-rw-r--r-- | extern/mantaflow/CMakeLists.txt | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/extern/mantaflow/CMakeLists.txt b/extern/mantaflow/CMakeLists.txt index d2f78f7ab6c..99d985578bd 100644 --- a/extern/mantaflow/CMakeLists.txt +++ b/extern/mantaflow/CMakeLists.txt @@ -54,6 +54,10 @@ if(WITH_OPENVDB) add_definitions(-DOPENVDB_STATICLIB) endif() +if(WIN32) + add_definitions(-D_USE_MATH_DEFINES) +endif() + set(INC ${MANTA_PP} ${MANTA_PP}/fileio |