diff options
author | Kévin Dietrich <kevin.dietrich@mailoo.org> | 2020-08-31 00:20:51 +0300 |
---|---|---|
committer | Kévin Dietrich <kevin.dietrich@mailoo.org> | 2020-08-31 00:49:38 +0300 |
commit | 429afe0c626a6d608385c6bc3a348b3ac8cfa8c0 (patch) | |
tree | 3240319bcb09b1737c5b2759a3ecbdd3b45ca59f /intern/cycles/graph | |
parent | 19363880a6770852a8f94565c162a987850d58e3 (diff) |
Cycles: introduce an ownership system to protect nodes from unwanted deletions.
Problem: the Blender synchronization process creates and tags nodes for usage. It does
this by directly adding and removing nodes from the scene data. If some node is not tagged
as used at the end of a synchronization, it then deletes the node from the scene. This poses
a problem when it comes to supporting procedural nodes who can create other nodes not known
by the Blender synchonization system, which will remove them.
Nodes now have a NodeOwner, which is set after creation. Those owners for now are the Scene
for scene level nodes and ShaderGraph for shader nodes. Instead of creating and deleting
nodes using `new` and `delete` explicitely, we now use `create_node` and `delete_node` methods
found on the owners. `delete_node` will assert that the owner is the right one.
Whenever a scene level node is created or deleted, the appropriate node manager is tagged for
an update, freeing this responsability from BlenderSync or other software exporters.
Concerning BlenderSync, the `id_maps` do not explicitely manipulate scene data anymore, they
only keep track of which nodes are used, employing the scene to create and delete them. To
achieve this, the ParticleSystem is now a Node, although it does not have any sockets.
This is part of T79131.
Reviewed By: #cycles, brecht
Maniphest Tasks: T79131
Differential Revision: https://developer.blender.org/D8540
Diffstat (limited to 'intern/cycles/graph')
-rw-r--r-- | intern/cycles/graph/node.cpp | 16 | ||||
-rw-r--r-- | intern/cycles/graph/node.h | 10 |
2 files changed, 26 insertions, 0 deletions
diff --git a/intern/cycles/graph/node.cpp b/intern/cycles/graph/node.cpp index c437c6fda1e..14e66959f4f 100644 --- a/intern/cycles/graph/node.cpp +++ b/intern/cycles/graph/node.cpp @@ -26,10 +26,16 @@ CCL_NAMESPACE_BEGIN /* Node Type */ +NodeOwner::~NodeOwner() +{ +} + Node::Node(const NodeType *type_, ustring name_) : name(name_), type(type_) { assert(type); + owner = nullptr; + /* assign non-empty name, convenient for debugging */ if (name.empty()) { name = type->name; @@ -679,4 +685,14 @@ bool Node::is_a(const NodeType *type_) return false; } +const NodeOwner *Node::get_owner() const +{ + return owner; +} + +void Node::set_owner(const NodeOwner *owner_) +{ + owner_ = owner; +} + CCL_NAMESPACE_END diff --git a/intern/cycles/graph/node.h b/intern/cycles/graph/node.h index 4473b8aca28..3c84dbdb4a7 100644 --- a/intern/cycles/graph/node.h +++ b/intern/cycles/graph/node.h @@ -31,6 +31,10 @@ struct Transform; /* Node */ +struct NodeOwner { + virtual ~NodeOwner(); +}; + struct Node { explicit Node(const NodeType *type, ustring name = ustring()); virtual ~Node() = 0; @@ -99,6 +103,12 @@ struct Node { ustring name; const NodeType *type; + + const NodeOwner *get_owner() const; + void set_owner(const NodeOwner *owner_); + + protected: + const NodeOwner *owner; }; CCL_NAMESPACE_END |