diff options
author | Sergey Sharybin <sergey> | 2021-12-07 20:50:48 +0300 |
---|---|---|
committer | Brecht Van Lommel <brecht@blender.org> | 2021-12-07 21:01:42 +0300 |
commit | 5e37f70307bdacedd0f7da65f8b385bc1426f21d (patch) | |
tree | dbf2d3085b28c5a674e18eb698fe0456836eec3c /intern/cycles/integrator/path_trace_display.h | |
parent | a92805bf24f52e1764a5f930bbe9e4e8fcc7e24d (diff) |
Fix T93350: Cycles renders shows black during rendering huge resolutions
The root of the issue is caused by Cycles ignoring OpenGL limitation on
the maximum resolution of textures: Cycles was allocating texture of the
final render resolution. It was exceeding limitation on certain GPUs and
driver.
The idea is simple: use multiple textures for the display, each of which
will fit into OpenGL limitations.
There is some code which allows the display driver to know when to start
the new tile. Also added some code to allow force graphics interop to be
re-created. The latter one ended up not used in the final version of the
patch, but it might be helpful for other drivers implementation.
The tile size is limited to 8K now as it is the safest size for textures
on many GPUs and OpenGL drivers.
Differential Revision: https://developer.blender.org/D13385
Diffstat (limited to 'intern/cycles/integrator/path_trace_display.h')
-rw-r--r-- | intern/cycles/integrator/path_trace_display.h | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/intern/cycles/integrator/path_trace_display.h b/intern/cycles/integrator/path_trace_display.h index 47014f43afa..be301e55359 100644 --- a/intern/cycles/integrator/path_trace_display.h +++ b/intern/cycles/integrator/path_trace_display.h @@ -38,14 +38,17 @@ class BufferParams; class PathTraceDisplay { public: - PathTraceDisplay(unique_ptr<DisplayDriver> driver); + explicit PathTraceDisplay(unique_ptr<DisplayDriver> driver); virtual ~PathTraceDisplay() = default; /* Reset the display for the new state of render session. Is called whenever session is reset, * which happens on changes like viewport navigation or viewport dimension change. * - * This call will configure parameters for a changed buffer and reset the texture state. */ - void reset(const BufferParams &buffer_params); + * This call will configure parameters for a changed buffer and reset the texture state. + * + * When the `reset_rendering` a complete displat reset happens. When it is false reset happens + * for a new state of the buffer parameters which is assumed to correspond to the next tile. */ + void reset(const BufferParams &buffer_params, bool reset_rendering); /* -------------------------------------------------------------------- * Update procedure. |