Welcome to mirror list, hosted at ThFree Co, Russian Federation.

git.blender.org/blender.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSergey Sharybin <sergey.vfx@gmail.com>2020-05-19 17:38:31 +0300
committerSergey Sharybin <sergey.vfx@gmail.com>2020-05-27 13:07:16 +0300
commit12c42738f3dad4c89d1b1b0935a4478c02005545 (patch)
tree1d1297d674b5b1fe16697b37892bf5d779e47cff /intern/opensubdiv/internal
parent8e9fdd2f3100b3f6dae7f73271fd01588065cf0f (diff)
OpenSubdiv: Add TODO avoid checking face-varying topology for equality
Diffstat (limited to 'intern/opensubdiv/internal')
-rw-r--r--intern/opensubdiv/internal/topology/topology_refiner_impl_compare.cc6
1 files changed, 6 insertions, 0 deletions
diff --git a/intern/opensubdiv/internal/topology/topology_refiner_impl_compare.cc b/intern/opensubdiv/internal/topology/topology_refiner_impl_compare.cc
index 2d0c5ec599f..d8f52e5bbb5 100644
--- a/intern/opensubdiv/internal/topology/topology_refiner_impl_compare.cc
+++ b/intern/opensubdiv/internal/topology/topology_refiner_impl_compare.cc
@@ -76,6 +76,10 @@ bool checkPreliminaryMatches(const TopologyRefinerImpl *topology_refiner_impl,
////////////////////////////////////////////////////////////////////////////////
// Compare attributes which affects on topology.
+//
+// TODO(sergey): Need to look into how auto-winding affects on face-varying
+// indexing and, possibly, move to mesh topology as well if winding affects
+// face-varyign as well.
bool checkSingleUVLayerMatch(const OpenSubdiv::Far::TopologyLevel &base_level,
const OpenSubdiv_Converter *converter,
@@ -136,6 +140,8 @@ bool TopologyRefinerImpl::isEqualToConverter(const OpenSubdiv_Converter *convert
return false;
}
+ // NOTE: Do after geometry check, to be sure topology does match and all
+ // indexing will go fine.
if (!blender::opensubdiv::checkTopologyAttributesMatch(this, converter)) {
return false;
}