diff options
| author | Jason Wilkins <Jason.A.Wilkins@gmail.com> | 2014-10-23 05:03:25 +0400 |
|---|---|---|
| committer | Jason Wilkins <Jason.A.Wilkins@gmail.com> | 2014-10-23 05:03:25 +0400 |
| commit | 88fe8962434b7fe00fa713a84c58d2dbee481e3b (patch) | |
| tree | 1a5a51cadd78e258924a13f0d1adcc1ebd7f6a0d /intern | |
| parent | db8e6311f899819dba509d516654071edd42fa54 (diff) | |
Checked each of my (jwilkins) XXX notes.
The ones in extern/glew-es have been changed to NOTE instead of XXX
GHOST_ContextEGL.cpp: It really does seem that it is not possible to query the swap interval using EGL
GHOST_WidnowCocoa.h: The comment referring to Carbon is clearly out of date, so I removed it.
math_geom.c: The node about not using tmax again is correct, but the code is kept for a future maintainer who will need to know how to compute it if they modify that code.
paint_image_proj.c (2698): The question about integer truncation does not appear to have been resolved. It still seems to be an incorrectly implementation of rounding (I'd suggest using the round function instead of this hack).
Diffstat (limited to 'intern')
| -rw-r--r-- | intern/ghost/intern/GHOST_ContextEGL.cpp | 4 | ||||
| -rw-r--r-- | intern/ghost/intern/GHOST_WindowCocoa.h | 14 |
2 files changed, 4 insertions, 14 deletions
diff --git a/intern/ghost/intern/GHOST_ContextEGL.cpp b/intern/ghost/intern/GHOST_ContextEGL.cpp index 6a9231835c5..520aa0fffb2 100644 --- a/intern/ghost/intern/GHOST_ContextEGL.cpp +++ b/intern/ghost/intern/GHOST_ContextEGL.cpp @@ -310,7 +310,9 @@ GHOST_TSuccess GHOST_ContextEGL::setSwapInterval(int interval) GHOST_TSuccess GHOST_ContextEGL::getSwapInterval(int &intervalOut) { - intervalOut = m_swap_interval; // XXX jwilkins: make sure there is no way to query this? + // This is a bit of a kludge because there does not seem to + // be a way to query the swap interval with EGL. + intervalOut = m_swap_interval; return GHOST_kSuccess; } diff --git a/intern/ghost/intern/GHOST_WindowCocoa.h b/intern/ghost/intern/GHOST_WindowCocoa.h index 1b6e8e63178..ac0973684d3 100644 --- a/intern/ghost/intern/GHOST_WindowCocoa.h +++ b/intern/ghost/intern/GHOST_WindowCocoa.h @@ -20,7 +20,7 @@ * * The Original Code is: all of this file. * - * Contributor(s): none yet. + * Contributor(s): Maarten Gribnau, Jason Wilkins * * ***** END GPL LICENSE BLOCK ***** */ @@ -47,18 +47,6 @@ class GHOST_SystemCocoa; -/** - * Window on Mac OSX/Cocoa. - * Carbon windows have a size widget in the lower right corner of the window. - * To force it to be visible, the height of the client rectangle is reduced so - * that applications do not draw in that area. GHOST will manage that area - * which is called the gutter. - * When OpenGL contexts are active, GHOST will use AGL_BUFFER_RECT to prevent - * OpenGL drawing outside the reduced client rectangle. - * XXX jwilkins: This comment seems out of date since we neither use Carbon nor AGL - * \author Maarten Gribnau - * \date May 23, 2001 - */ class GHOST_WindowCocoa : public GHOST_Window { public: /** |