diff options
| author | Bastien Montagne <montagne29@wanadoo.fr> | 2016-01-27 20:04:50 +0300 |
|---|---|---|
| committer | Bastien Montagne <montagne29@wanadoo.fr> | 2016-01-27 20:04:50 +0300 |
| commit | 66aa4af83611de2c59d9e8ab4ded1b48bec4a635 (patch) | |
| tree | da0fe05c1c27905fa0ea836345b9dd650af034b1 /release | |
| parent | 4e2eea63a4d754744d94de3937d0b29d87ae13f7 (diff) | |
Fix T47252: FileBrowser: buffer overflow with scripts defining too long 'filter_glob' string.
Fixed this with three changes:
* filter_glob is now 255 char max (63 could be a bit limited in some rare cases).
* IO templates now explicitely define max len of that property (such that scripters are aware of the limit).
* ED_fileselect_set_params() is now safe regarding too long strings from a 'filter_glob' op property.
Diffstat (limited to 'release')
| -rw-r--r-- | release/scripts/templates_py/operator_file_export.py | 1 | ||||
| -rw-r--r-- | release/scripts/templates_py/operator_file_import.py | 1 |
2 files changed, 2 insertions, 0 deletions
diff --git a/release/scripts/templates_py/operator_file_export.py b/release/scripts/templates_py/operator_file_export.py index 9511cb163bc..38c88069845 100644 --- a/release/scripts/templates_py/operator_file_export.py +++ b/release/scripts/templates_py/operator_file_export.py @@ -28,6 +28,7 @@ class ExportSomeData(Operator, ExportHelper): filter_glob = StringProperty( default="*.txt", options={'HIDDEN'}, + maxlen=255, # Max internal buffer length, longer would be clamped. ) # List of operator properties, the attributes will be assigned diff --git a/release/scripts/templates_py/operator_file_import.py b/release/scripts/templates_py/operator_file_import.py index 9940a1b98eb..0ec57544f3d 100644 --- a/release/scripts/templates_py/operator_file_import.py +++ b/release/scripts/templates_py/operator_file_import.py @@ -31,6 +31,7 @@ class ImportSomeData(Operator, ImportHelper): filter_glob = StringProperty( default="*.txt", options={'HIDDEN'}, + maxlen=255, # Max internal buffer length, longer would be clamped. ) # List of operator properties, the attributes will be assigned |