Welcome to mirror list, hosted at ThFree Co, Russian Federation.

git.blender.org/blender.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPhilipp Oeser <info@graphics-engineer.com>2020-10-09 15:00:18 +0300
committerPhilipp Oeser <info@graphics-engineer.com>2021-01-09 17:02:14 +0300
commit6154aa1529b77a9ede5afdac148048e6eb02dbf3 (patch)
tree6b375da98c01507a47fe76e906460e3e05571b95 /release
parentfa82a15676eb37a7e73d1e3a0e8095684842376d (diff)
Cleanup: remove redundant decorator for eevee 'overscan_size'
All eevee scene properties are not animatable due to `RNA_define_animate_sdna(false)` so there is no need for an animation decorator here (would not show anyways). Not sure if setting use_property_decorate to False and then manually adding one again was a hack in rB7fc60bff14a6 to get the alignment right, but seems to work good now without it. Note: there also seems to be an inconsistency here generally: - Eevee reserves room for an animation decorator in almost every panel (except for "Sampling" and "Indirect Lighting") even though almost none are animatable (except for stuff in "Hair" and "Film"). This looks nice if multiple panels are expanded (except for mentioned "Sampling" and "Indirect Lighting" -- maybe these should also reserve the room?) - Cycles does not use animation decorators at all (even though pretty much everything is animatable here -- maybe these should also use animation decorators?) - Then there is also the 'shared' "Grease Pencil", "Freestyle" and "Colormanagement" -- these dont use animation decorators, but some stuff is animatable... Regarding the note: not sure what the guidelines here are, if this is isolated to each panel then there is lots of stuff for eevee that could set use_property_decorate to False, if multiple open panels are considered (for nice visual consistency between them), then there is romm for improvement elsewhere, too. Maniphest Tasks: T81411 Differential Revision: https://developer.blender.org/D9164
Diffstat (limited to 'release')
-rw-r--r--release/scripts/startup/bl_ui/properties_render.py2
1 files changed, 0 insertions, 2 deletions
diff --git a/release/scripts/startup/bl_ui/properties_render.py b/release/scripts/startup/bl_ui/properties_render.py
index ae2a7a8ccb9..b326a23b390 100644
--- a/release/scripts/startup/bl_ui/properties_render.py
+++ b/release/scripts/startup/bl_ui/properties_render.py
@@ -486,14 +486,12 @@ class RENDER_PT_eevee_film(RenderButtonsPanel, Panel):
col.prop(rd, "film_transparent", text="Transparent")
col = layout.column(align=False, heading="Overscan")
- col.use_property_decorate = False
row = col.row(align=True)
sub = row.row(align=True)
sub.prop(props, "use_overscan", text="")
sub = sub.row(align=True)
sub.active = props.use_overscan
sub.prop(props, "overscan_size", text="")
- row.prop_decorator(props, "overscan_size")
class RENDER_PT_eevee_hair(RenderButtonsPanel, Panel):