diff options
author | Brecht Van Lommel <brecht@blender.org> | 2022-05-17 16:31:37 +0300 |
---|---|---|
committer | Brecht Van Lommel <brecht@blender.org> | 2022-05-17 17:14:15 +0300 |
commit | 0609b4bb491eae28b7aff411f54d732b458d6ae9 (patch) | |
tree | ecf7b06626f11ae73a0223723e62e5f998222000 /source/blender/blenkernel/BKE_subdiv_modifier.h | |
parent | dbc439e41a1aaa17e237ccf058c75ea8975bc79b (diff) |
Fix T98052: Eevee / Workbench background render crash with GPU subdivision
The problem is that depsgraph evaluation happens before the OpenGL context
is initialized, and so modifier evaluation happens without GPU subdivision.
Later the BKE_subsurf_modifier_can_do_gpu_subdiv test in the draw code gives
a different result.
This just checks if the mesh has information for GPU subdivision in the draw
code, and if so uses it. This is only set if the test for supported GPU
subdivision passes in the modifier evaluation.
Additionally it may be good to perform OpenGL context initialization earlier
so background render can take advantage of GPU subdivision, but this is more
complicated.
Differential Revision: https://developer.blender.org/D14969
Diffstat (limited to 'source/blender/blenkernel/BKE_subdiv_modifier.h')
-rw-r--r-- | source/blender/blenkernel/BKE_subdiv_modifier.h | 10 |
1 files changed, 3 insertions, 7 deletions
diff --git a/source/blender/blenkernel/BKE_subdiv_modifier.h b/source/blender/blenkernel/BKE_subdiv_modifier.h index e9de7d1532e..4ad17610207 100644 --- a/source/blender/blenkernel/BKE_subdiv_modifier.h +++ b/source/blender/blenkernel/BKE_subdiv_modifier.h @@ -42,18 +42,14 @@ bool BKE_subsurf_modifier_force_disable_gpu_evaluation_for_mesh( * \param skip_check_is_last: When true, we assume that the modifier passed is the last enabled * modifier in the stack. */ -bool BKE_subsurf_modifier_can_do_gpu_subdiv_ex(const struct Scene *scene, - const struct Object *ob, - const struct Mesh *mesh, - const struct SubsurfModifierData *smd, - int required_mode, - bool skip_check_is_last); - bool BKE_subsurf_modifier_can_do_gpu_subdiv(const struct Scene *scene, const struct Object *ob, const struct Mesh *mesh, + const struct SubsurfModifierData *smd, int required_mode); +bool BKE_subsurf_modifier_has_gpu_subdiv(const struct Mesh *mesh); + extern void (*BKE_subsurf_modifier_free_gpu_cache_cb)(struct Subdiv *subdiv); /** |