Welcome to mirror list, hosted at ThFree Co, Russian Federation.

git.blender.org/blender.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSergey Sharybin <sergey.vfx@gmail.com>2014-01-10 13:39:06 +0400
committerSergey Sharybin <sergey.vfx@gmail.com>2014-01-13 13:57:51 +0400
commitbc989497deeaf2ec79ccfbe7b5e43509eb867b06 (patch)
tree40158c4ecf95f458d82ae234435db60590ca5e91 /source/blender/blenkernel/depsgraph_private.h
parente618d8238e0e065bdfd2d9332ba7231e870a7e7d (diff)
Fix T38139: Objects which are in cyclic dependency are not updated
Graph traversal which is based on counting parents which are still to be updated fails in cases there are cycles in the graph. If there are cyclic dependencies in the scene all the objects from the cycles will be updated in a single thread now one by one. This makes blender behave the same way as it was before multi-threaded DAG landed to master. This needed to tweak depsgraph a bit so now dag_check_cycle() sets is_acyclic field of DAG forest if there are cycles in the graph. TODO: It might be possible to save some time on evaluation when all the tagged objects were updated in multi-threaded DAG traversal.
Diffstat (limited to 'source/blender/blenkernel/depsgraph_private.h')
-rw-r--r--source/blender/blenkernel/depsgraph_private.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/source/blender/blenkernel/depsgraph_private.h b/source/blender/blenkernel/depsgraph_private.h
index e178667e5a5..bf0179a4911 100644
--- a/source/blender/blenkernel/depsgraph_private.h
+++ b/source/blender/blenkernel/depsgraph_private.h
@@ -127,7 +127,7 @@ typedef struct DagForest {
ListBase DagNode;
struct GHash *nodeHash;
int numNodes;
- int is_acyclic;
+ bool is_acyclic;
int time; /* for flushing/tagging, compare with node->lasttime */
} DagForest;