diff options
author | Bastien Montagne <mont29> | 2021-11-29 16:20:58 +0300 |
---|---|---|
committer | Bastien Montagne <bastien@blender.org> | 2021-11-29 16:22:38 +0300 |
commit | e5e8db73df86ee04260c5f2bd2c61dfa8eb7943f (patch) | |
tree | 46a5840efb51a363f17e64b93d5132679a5dbec4 /source/blender/blenkernel/intern/bpath_test.cc | |
parent | 6ae34bb0714859d9ef0b7fa2aceb16b4531df48f (diff) |
Refactor BKE_bpath module.
The main goal of this refactor is to make BPath module use `IDTypeInfo`,
and move each ID-specific part of the `foreach_path` looper into their
own IDTypeInfo struct, using a new `foreach_path` callback.
Additionally, following improvements/cleanups are included:
* Attempt to get better, more consistent namings.
** In particular, move from `path_visitor` to more standard `foreach_path`.
* Update and extend documentation.
** API doc was moved to header, according to recent discussions on this
topic.
* Remove `BKE_bpath_relocate_visitor` from API, this is specific
callback that belongs in `lib_id.c` user code.
NOTE: This commit is expected to be 100% non-behavioral-change. This
implies that several potential further changes were only noted as
comments (like using a more generic solution for
`lib_id_library_local_paths`, addressing inconsistencies like path of
packed libraries always being skipped, regardless of the
`BKE_BPATH_FOREACH_PATH_SKIP_PACKED` `eBPathForeachFlag` flag value,
etc.).
NOTE: basic unittests were added to master already in
rBdcc500e5a265093bc9cc.
Reviewed By: brecht
Differential Revision: https://developer.blender.org/D13381
Diffstat (limited to 'source/blender/blenkernel/intern/bpath_test.cc')
-rw-r--r-- | source/blender/blenkernel/intern/bpath_test.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/source/blender/blenkernel/intern/bpath_test.cc b/source/blender/blenkernel/intern/bpath_test.cc index 12dabb11e96..ee921cc2135 100644 --- a/source/blender/blenkernel/intern/bpath_test.cc +++ b/source/blender/blenkernel/intern/bpath_test.cc @@ -160,7 +160,7 @@ TEST_F(BPathTest, list_backup_restore) MovieClip *movie_clip = reinterpret_cast<MovieClip *>(bmain->movieclips.first); BLI_strncpy(movie_clip->filepath, MOVIECLIP_PATH_ABSOLUTE, sizeof(movie_clip->filepath)); - void *path_list_handle = BKE_bpath_list_backup(bmain, 0); + void *path_list_handle = BKE_bpath_list_backup(bmain, static_cast<eBPathForeachFlag>(0)); ListBase *path_list = reinterpret_cast<ListBase *>(path_list_handle); EXPECT_EQ(BLI_listbase_count(path_list), 2); @@ -169,7 +169,7 @@ TEST_F(BPathTest, list_backup_restore) text->filepath = BLI_strdup(TEXT_PATH_ABSOLUTE); BLI_strncpy(movie_clip->filepath, MOVIECLIP_PATH_RELATIVE, sizeof(movie_clip->filepath)); - BKE_bpath_list_restore(bmain, 0, path_list_handle); + BKE_bpath_list_restore(bmain, static_cast<eBPathForeachFlag>(0), path_list_handle); EXPECT_STREQ(text->filepath, TEXT_PATH_RELATIVE); EXPECT_STREQ(movie_clip->filepath, MOVIECLIP_PATH_ABSOLUTE); |