Welcome to mirror list, hosted at ThFree Co, Russian Federation.

git.blender.org/blender.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBrecht Van Lommel <brechtvanlommel@pandora.be>2013-05-14 20:22:53 +0400
committerBrecht Van Lommel <brechtvanlommel@pandora.be>2013-05-14 20:22:53 +0400
commit8ef3c42f80c2227ece7500c809f44946467e6fab (patch)
treec28afe46673325c14437691d5abcf19b77ec2b42 /source/blender/blenkernel/intern/constraint.c
parent44dfc76154c0964ade17b5e2d12dda74f8328e30 (diff)
Fix #35347: constraints with vertex group targets were not using the vertex group
weights, it assumed all weights were 1. This gave very different results with the new bevel modifier due to slightly different vertex group interpolation.
Diffstat (limited to 'source/blender/blenkernel/intern/constraint.c')
-rw-r--r--source/blender/blenkernel/intern/constraint.c20
1 files changed, 11 insertions, 9 deletions
diff --git a/source/blender/blenkernel/intern/constraint.c b/source/blender/blenkernel/intern/constraint.c
index af5a20e97b4..cee796c4cab 100644
--- a/source/blender/blenkernel/intern/constraint.c
+++ b/source/blender/blenkernel/intern/constraint.c
@@ -380,29 +380,31 @@ static void contarget_get_mesh_mat(Object *ob, const char *substring, float mat[
if (dm) {
MDeformVert *dvert = dm->getVertDataArray(dm, CD_MDEFORMVERT);
int numVerts = dm->getNumVerts(dm);
- int i, count = 0;
+ int i;
float co[3], nor[3];
/* check that dvert is a valid pointers (just in case) */
if (dvert) {
MDeformVert *dv = dvert;
+ float weightsum = 0.0f;
+
/* get the average of all verts with that are in the vertex-group */
for (i = 0; i < numVerts; i++, dv++) {
MDeformWeight *dw = defvert_find_index(dv, defgroup);
- if (dw && dw->weight != 0.0f) {
+
+ if (dw && dw->weight > 0.0f) {
dm->getVertCo(dm, i, co);
dm->getVertNo(dm, i, nor);
- add_v3_v3(vec, co);
- add_v3_v3(normal, nor);
- count++;
-
+ madd_v3_v3fl(vec, co, dw->weight);
+ madd_v3_v3fl(normal, nor, dw->weight);
+ weightsum += dw->weight;
}
}
/* calculate averages of normal and coordinates */
- if (count > 0) {
- mul_v3_fl(vec, 1.0f / count);
- mul_v3_fl(normal, 1.0f / count);
+ if (weightsum > 0) {
+ mul_v3_fl(vec, 1.0f / weightsum);
+ mul_v3_fl(normal, 1.0f / weightsum);
}