diff options
author | Hans Goudey <h.goudey@me.com> | 2022-10-05 21:44:02 +0300 |
---|---|---|
committer | Hans Goudey <h.goudey@me.com> | 2022-10-05 21:48:01 +0300 |
commit | 548a2cbe06b23d90b0e09da49fc854178c270b8a (patch) | |
tree | 8706b5be97ace0ff0ca18d4109586ccb5cf0a666 /source/blender/blenkernel/intern/editmesh_tangent.cc | |
parent | 6306d747b770685f38f95bc57f8681335ddfa506 (diff) |
Cleanup: Clang tidy
Also remove unnecessary struct keywords in C++ files.
Diffstat (limited to 'source/blender/blenkernel/intern/editmesh_tangent.cc')
-rw-r--r-- | source/blender/blenkernel/intern/editmesh_tangent.cc | 20 |
1 files changed, 7 insertions, 13 deletions
diff --git a/source/blender/blenkernel/intern/editmesh_tangent.cc b/source/blender/blenkernel/intern/editmesh_tangent.cc index 016cf6acbcc..12799afd2f7 100644 --- a/source/blender/blenkernel/intern/editmesh_tangent.cc +++ b/source/blender/blenkernel/intern/editmesh_tangent.cc @@ -94,12 +94,10 @@ struct SGLSLEditMeshToTangent { const float *uv = (const float *)BM_ELEM_CD_GET_VOID_P(l, cd_loop_uv_offset); return mikk::float3(uv[0], uv[1], 1.0f); } - else { - const float *orco_p = orco[BM_elem_index_get(l->v)]; - float u, v; - map_to_sphere(&u, &v, orco_p[0], orco_p[1], orco_p[2]); - return mikk::float3(u, v, 1.0f); - } + const float *orco_p = orco[BM_elem_index_get(l->v)]; + float u, v; + map_to_sphere(&u, &v, orco_p[0], orco_p[1], orco_p[2]); + return mikk::float3(u, v, 1.0f); } mikk::float3 GetNormal(const uint face_num, const uint vert_index) @@ -108,17 +106,13 @@ struct SGLSLEditMeshToTangent { if (precomputedLoopNormals) { return mikk::float3(precomputedLoopNormals[BM_elem_index_get(l)]); } - else if (BM_elem_flag_test(l->f, BM_ELEM_SMOOTH) == 0) { /* flat */ + if (BM_elem_flag_test(l->f, BM_ELEM_SMOOTH) == 0) { /* flat */ if (precomputedFaceNormals) { return mikk::float3(precomputedFaceNormals[BM_elem_index_get(l->f)]); } - else { - return mikk::float3(l->f->no); - } - } - else { - return mikk::float3(l->v->no); + return mikk::float3(l->f->no); } + return mikk::float3(l->v->no); } void SetTangentSpace(const uint face_num, |