diff options
author | Sergey Sharybin <sergey@blender.org> | 2022-02-16 13:56:04 +0300 |
---|---|---|
committer | Sergey Sharybin <sergey@blender.org> | 2022-02-16 17:40:03 +0300 |
commit | 03ff58b67d50a714c5609e584a6942996cfdee1b (patch) | |
tree | d48c540ef4252afb2ec5966273a1834318e9f6da /source/blender/blenkernel/intern/object.cc | |
parent | 7e312f89d970744eb90351de01101358613b89ec (diff) |
Cleanup: Use const qualifier in modifier data copy
Fix possible overflow of Modifier UUID
The code prior this change was re-generating modifier's session UUID
prior to copying this id from the source. This approach has a higher
risk of modifiers session UUID to overflow and start colliding with
existing modifiers.
This change makes it so that modifier copy does not re-generated the
session UUID unless it is needed.
Differential Revision: https://developer.blender.org/D14125
Diffstat (limited to 'source/blender/blenkernel/intern/object.cc')
-rw-r--r-- | source/blender/blenkernel/intern/object.cc | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/source/blender/blenkernel/intern/object.cc b/source/blender/blenkernel/intern/object.cc index 579e61750f0..3a8d7d6bc8a 100644 --- a/source/blender/blenkernel/intern/object.cc +++ b/source/blender/blenkernel/intern/object.cc @@ -1599,9 +1599,7 @@ bool BKE_object_modifier_stack_copy(Object *ob_dst, continue; } - ModifierData *md_dst = BKE_modifier_new(md_src->type); - BLI_strncpy(md_dst->name, md_src->name, sizeof(md_dst->name)); - BKE_modifier_copydata_ex(md_src, md_dst, flag_subdata); + ModifierData *md_dst = BKE_modifier_copy_ex(md_src, flag_subdata); BLI_addtail(&ob_dst->modifiers, md_dst); } |