diff options
author | Dalai Felinto <dfelinto@gmail.com> | 2018-05-16 22:40:05 +0300 |
---|---|---|
committer | Dalai Felinto <dfelinto@gmail.com> | 2018-05-17 00:13:28 +0300 |
commit | e51bf11b15cb2c26b2bd33c377e1eb74fa8bde38 (patch) | |
tree | 0772e04362ca16c1511ccc48517e50e061187f22 /source/blender/blenkernel | |
parent | 09e419fa8da930b13651997417a434de308e697d (diff) |
Remove ViewLayer settings - cleanup 1/2
Diffstat (limited to 'source/blender/blenkernel')
-rw-r--r-- | source/blender/blenkernel/BKE_layer.h | 28 | ||||
-rw-r--r-- | source/blender/blenkernel/intern/blender.c | 2 | ||||
-rw-r--r-- | source/blender/blenkernel/intern/layer.c | 426 | ||||
-rw-r--r-- | source/blender/blenkernel/intern/scene.c | 33 |
4 files changed, 4 insertions, 485 deletions
diff --git a/source/blender/blenkernel/BKE_layer.h b/source/blender/blenkernel/BKE_layer.h index 3205392a795..4bfb00e6493 100644 --- a/source/blender/blenkernel/BKE_layer.h +++ b/source/blender/blenkernel/BKE_layer.h @@ -56,8 +56,6 @@ struct SceneCollection; struct ViewLayer; struct WorkSpace; -void BKE_layer_exit(void); - struct ViewLayer *BKE_view_layer_default_view(const struct Scene *scene); struct ViewLayer *BKE_view_layer_default_render(const struct Scene *scene); struct ViewLayer *BKE_view_layer_from_workspace_get(const struct Scene *scene, const struct WorkSpace *workspace); @@ -132,36 +130,10 @@ void BKE_override_view_layer_int_add(struct ViewLayer *view_layer, int id_type, void BKE_override_layer_collection_boolean_add(struct LayerCollection *layer_collection, int id_type, const char *data_path, const bool value); -/* engine settings */ -typedef void (*EngineSettingsCB)(struct RenderEngine *engine, struct IDProperty *props); - -struct IDProperty *BKE_layer_collection_engine_scene_get(struct Scene *scene, const char *engine_name); -void BKE_layer_collection_engine_settings_callback_register(struct Main *bmain, const char *engine_name, EngineSettingsCB func); -void BKE_layer_collection_engine_settings_callback_free(void); -void BKE_layer_collection_engine_settings_create(struct IDProperty *root); -void BKE_layer_collection_engine_settings_validate_scene(struct Scene *scene); - -struct IDProperty *BKE_view_layer_engine_evaluated_get(struct ViewLayer *view_layer, const char *engine_name); -struct IDProperty *BKE_view_layer_engine_scene_get(struct Scene *scene, const char *engine_name); -void BKE_view_layer_engine_settings_callback_register(struct Main *bmain, const char *engine_name, EngineSettingsCB func); -void BKE_view_layer_engine_settings_callback_free(void); -void BKE_view_layer_engine_settings_validate_scene(struct Scene *scene); -void BKE_view_layer_engine_settings_create(struct IDProperty *root); - -void BKE_collection_engine_property_add_float(struct IDProperty *props, const char *name, float value); -void BKE_collection_engine_property_add_float_array( - struct IDProperty *props, const char *name, const float *values, const int array_length); -void BKE_collection_engine_property_add_int(struct IDProperty *props, const char *name, int value); -void BKE_collection_engine_property_add_bool(struct IDProperty *props, const char *name, bool value); - int BKE_collection_engine_property_value_get_int(struct IDProperty *props, const char *name); float BKE_collection_engine_property_value_get_float(struct IDProperty *props, const char *name); const float *BKE_collection_engine_property_value_get_float_array(struct IDProperty *props, const char *name); bool BKE_collection_engine_property_value_get_bool(struct IDProperty *props, const char *name); -void BKE_collection_engine_property_value_set_int(struct IDProperty *props, const char *name, int value); -void BKE_collection_engine_property_value_set_float(struct IDProperty *props, const char *name, float value); -void BKE_collection_engine_property_value_set_float_array(struct IDProperty *props, const char *name, const float *values); -void BKE_collection_engine_property_value_set_bool(struct IDProperty *props, const char *name, bool value); /* evaluation */ diff --git a/source/blender/blenkernel/intern/blender.c b/source/blender/blenkernel/intern/blender.c index 236b965ec34..3f78b096115 100644 --- a/source/blender/blenkernel/intern/blender.c +++ b/source/blender/blenkernel/intern/blender.c @@ -104,8 +104,6 @@ void BKE_blender_free(void) BKE_sequencer_cache_destruct(); IMB_moviecache_destruct(); - BKE_layer_exit(); - free_nodesystem(); } diff --git a/source/blender/blenkernel/intern/layer.c b/source/blender/blenkernel/intern/layer.c index bdc1ceda46d..c8fe2e111d4 100644 --- a/source/blender/blenkernel/intern/layer.c +++ b/source/blender/blenkernel/intern/layer.c @@ -68,10 +68,6 @@ static void layer_collection_free(ViewLayer *view_layer, LayerCollection *lc); static void layer_collection_objects_populate(ViewLayer *view_layer, LayerCollection *lc, ListBase *objects); static LayerCollection *layer_collection_add(ViewLayer *view_layer, LayerCollection *parent, SceneCollection *sc); static LayerCollection *find_layer_collection_by_scene_collection(LayerCollection *lc, const SceneCollection *sc); -static IDProperty *collection_engine_settings_create(struct EngineSettingsCB_Type *ces_type, const bool populate); -static IDProperty *collection_engine_get(IDProperty *root, const char *engine_name); -static void collection_engine_settings_init(IDProperty *root, const bool populate); -static void layer_engine_settings_init(IDProperty *root, const bool populate); static void object_bases_iterator_next(BLI_Iterator *iter, const int flag); /* RenderLayer */ @@ -200,11 +196,6 @@ void BKE_view_layer_free_ex(ViewLayer *view_layer, const bool do_id_user) } BLI_freelistN(&view_layer->layer_collections); - if (view_layer->properties_evaluated) { - IDP_FreeProperty(view_layer->properties_evaluated); - MEM_freeN(view_layer->properties_evaluated); - } - for (ViewLayerEngineData *sled = view_layer->drawdata.first; sled; sled = sled->next) { if (sled->storage) { if (sled->free) { @@ -475,7 +466,6 @@ void BKE_view_layer_copy_data( BKE_freestyle_config_copy(&view_layer_dst->freestyle_config, &view_layer_src->freestyle_config, flag); view_layer_dst->stats = NULL; - view_layer_dst->properties_evaluated = NULL; /* we start fresh with no overrides and no visibility flags set * instead of syncing both trees we simply unlink and relink the scene collection */ @@ -1392,216 +1382,8 @@ void BKE_override_layer_collection_boolean_add(struct LayerCollection *layer_col } /* ---------------------------------------------------------------------- */ -/* Engine Settings */ - -ListBase R_layer_collection_engines_settings_callbacks = {NULL, NULL}; -ListBase R_view_layer_engines_settings_callbacks = {NULL, NULL}; - -typedef struct EngineSettingsCB_Type { - struct EngineSettingsCB_Type *next, *prev; - - char name[MAX_NAME]; /* engine name */ - - EngineSettingsCB callback; - -} EngineSettingsCB_Type; - -static void create_engine_settings_scene(IDProperty *root, EngineSettingsCB_Type *es_type) -{ - if (collection_engine_get(root, es_type->name)) { - return; - } - - IDProperty *props = collection_engine_settings_create(es_type, true); - IDP_AddToGroup(root, props); -} - -static void create_layer_collection_engine_settings_scene(Scene *scene, EngineSettingsCB_Type *es_type) -{ - create_engine_settings_scene(scene->collection_properties, es_type); -} - -static void create_view_layer_engine_settings_scene(Scene *scene, EngineSettingsCB_Type *es_type) -{ - create_engine_settings_scene(scene->layer_properties, es_type); -} - -static void create_layer_collection_engines_settings_scene(Scene *scene, EngineSettingsCB_Type *es_type) -{ - /* Populate the scene with the new settings. */ - create_layer_collection_engine_settings_scene(scene, es_type); -} - -static void create_view_layer_engines_settings_scene(Scene *scene, EngineSettingsCB_Type *es_type) -{ - /* Populate the scene with the new settings. */ - create_view_layer_engine_settings_scene(scene, es_type); -} - -static EngineSettingsCB_Type *engine_settings_callback_register(const char *engine_name, EngineSettingsCB func, ListBase *lb) -{ - EngineSettingsCB_Type *es_type; - - /* Cleanup in case it existed. */ - es_type = BLI_findstring(lb, engine_name, offsetof(EngineSettingsCB_Type, name)); - - if (es_type) { - BLI_remlink(lb, es_type); - MEM_freeN(es_type); - } - - es_type = MEM_callocN(sizeof(EngineSettingsCB_Type), __func__); - BLI_strncpy_utf8(es_type->name, engine_name, sizeof(es_type->name)); - es_type->callback = func; - BLI_addtail(lb, es_type); - - return es_type; -} - -void BKE_layer_collection_engine_settings_callback_register( - Main *bmain, const char *engine_name, EngineSettingsCB func) -{ - EngineSettingsCB_Type *es_type = - engine_settings_callback_register(engine_name, func, &R_layer_collection_engines_settings_callbacks); - - if (bmain) { - /* Populate all of the collections of the scene with those settings. */ - for (Scene *scene = bmain->scene.first; scene; scene = scene->id.next) { - create_layer_collection_engines_settings_scene(scene, es_type); - } - } -} - -void BKE_view_layer_engine_settings_callback_register( - Main *bmain, const char *engine_name, EngineSettingsCB func) -{ - EngineSettingsCB_Type *es_type = - engine_settings_callback_register(engine_name, func, &R_view_layer_engines_settings_callbacks); - - if (bmain) { - /* Populate all of the collections of the scene with those settings. */ - for (Scene *scene = bmain->scene.first; scene; scene = scene->id.next) { - create_view_layer_engines_settings_scene(scene, es_type); - } - } -} - -void BKE_layer_collection_engine_settings_callback_free(void) -{ - BLI_freelistN(&R_layer_collection_engines_settings_callbacks); -} - -void BKE_view_layer_engine_settings_callback_free(void) -{ - BLI_freelistN(&R_view_layer_engines_settings_callbacks); -} - -/** - * Create a root IDProperty for this engine - * - * \param populate whether we want to pre-fill the collection with the default properties - */ -static IDProperty *collection_engine_settings_create(EngineSettingsCB_Type *es_type, const bool populate) -{ - IDProperty *props; - IDPropertyTemplate val = {0}; - - props = IDP_New(IDP_GROUP, &val, es_type->name); - props->subtype = IDP_GROUP_SUB_ENGINE_RENDER; - - /* properties */ - if (populate) { - es_type->callback(NULL, props); - } - - return props; -} - -static void layer_collection_create_render_settings(IDProperty *root, const bool populate) -{ - EngineSettingsCB_Type *es_type; - for (es_type = R_layer_collection_engines_settings_callbacks.first; es_type; es_type = es_type->next) { - IDProperty *props = collection_engine_settings_create(es_type, populate); - IDP_AddToGroup(root, props); - } -} - -static void view_layer_create_render_settings(IDProperty *root, const bool populate) -{ - EngineSettingsCB_Type *es_type; - for (es_type = R_view_layer_engines_settings_callbacks.first; es_type; es_type = es_type->next) { - IDProperty *props = collection_engine_settings_create(es_type, populate); - IDP_AddToGroup(root, props); - } -} - -/** - * Return collection enginne settings for either Object s of LayerCollection s - */ -static IDProperty *collection_engine_get(IDProperty *root, const char *engine_name) -{ - return IDP_GetPropertyFromGroup(root, engine_name); -} - -/** - * Return layer collection engine settings for specified engine in the scene - */ -IDProperty *BKE_layer_collection_engine_scene_get(Scene *scene, const char *engine_name) -{ - return collection_engine_get(scene->collection_properties, engine_name); -} - -/** - * Return scene layer engine settings for specified engine in the scene - */ -IDProperty *BKE_view_layer_engine_scene_get(Scene *scene, const char *engine_name) -{ - return collection_engine_get(scene->layer_properties, engine_name); -} - -/** - * Return scene layer evaluated engine settings for specified engine - */ -IDProperty *BKE_view_layer_engine_evaluated_get(ViewLayer *view_layer, const char *engine_name) -{ - return collection_engine_get(view_layer->properties_evaluated, engine_name); -} - -/* ---------------------------------------------------------------------- */ /* Engine Settings Properties */ -void BKE_collection_engine_property_add_float(IDProperty *props, const char *name, float value) -{ - IDPropertyTemplate val = {0}; - val.f = value; - IDP_AddToGroup(props, IDP_New(IDP_FLOAT, &val, name)); -} - -void BKE_collection_engine_property_add_float_array( - IDProperty *props, const char *name, const float *values, const int array_length) -{ - IDPropertyTemplate val = {0}; - val.array.len = array_length; - val.array.type = IDP_FLOAT; - - IDProperty *idprop = IDP_New(IDP_ARRAY, &val, name); - memcpy(IDP_Array(idprop), values, sizeof(float) * idprop->len); - IDP_AddToGroup(props, idprop); -} - -void BKE_collection_engine_property_add_int(IDProperty *props, const char *name, int value) -{ - IDPropertyTemplate val = {0}; - val.i = value; - IDP_AddToGroup(props, IDP_New(IDP_INT, &val, name)); -} - -void BKE_collection_engine_property_add_bool(IDProperty *props, const char *name, bool value) -{ - IDPropertyTemplate val = {0}; - val.i = value; - IDP_AddToGroup(props, IDP_New(IDP_INT, &val, name)); -} int BKE_collection_engine_property_value_get_int(IDProperty *props, const char *name) { @@ -1627,173 +1409,6 @@ bool BKE_collection_engine_property_value_get_bool(IDProperty *props, const char return idprop ? IDP_Int(idprop) : 0; } -void BKE_collection_engine_property_value_set_int(IDProperty *props, const char *name, int value) -{ - IDProperty *idprop = IDP_GetPropertyFromGroup(props, name); - IDP_Int(idprop) = value; -} - -void BKE_collection_engine_property_value_set_float(IDProperty *props, const char *name, float value) -{ - IDProperty *idprop = IDP_GetPropertyFromGroup(props, name); - IDP_Float(idprop) = value; -} - -void BKE_collection_engine_property_value_set_float_array(IDProperty *props, const char *name, const float *values) -{ - IDProperty *idprop = IDP_GetPropertyFromGroup(props, name); - memcpy(IDP_Array(idprop), values, sizeof(float) * idprop->len); -} - -void BKE_collection_engine_property_value_set_bool(IDProperty *props, const char *name, bool value) -{ - IDProperty *idprop = IDP_GetPropertyFromGroup(props, name); - IDP_Int(idprop) = value; -} - -/* Engine Settings recalculate */ - -/* get all the default settings defined in scene and merge them here */ -static void collection_engine_settings_init(IDProperty *root, const bool populate) -{ - /* render engines */ - layer_collection_create_render_settings(root, populate); -} - -/* get all the default settings defined in scene and merge them here */ -static void layer_engine_settings_init(IDProperty *root, const bool populate) -{ - /* render engines */ - view_layer_create_render_settings(root, populate); -} - -/** - * Initialize the layer collection render setings - * It's used mainly for scenes - */ -void BKE_layer_collection_engine_settings_create(IDProperty *root) -{ - collection_engine_settings_init(root, true); -} - -/** - * Initialize the render setings - * It's used mainly for scenes - */ -void BKE_view_layer_engine_settings_create(IDProperty *root) -{ - layer_engine_settings_init(root, true); -} - -/** - * Reference of IDProperty group scene collection settings - * Used when reading blendfiles, to see if there is any missing settings. - */ -static struct { - struct { - IDProperty *collection_properties; - IDProperty *render_settings; - } scene; - IDProperty *view_layer; - IDProperty *layer_collection; -} root_reference = { - .scene = {NULL, NULL}, - .view_layer = NULL, - .layer_collection = NULL, -}; - -/** - * Free the reference scene collection settings IDProperty group. - */ -static void engine_settings_validate_init(void) -{ - IDPropertyTemplate val = {0}; - - /* LayerCollection engine settings. */ - if (root_reference.scene.collection_properties == NULL) { - root_reference.scene.collection_properties = IDP_New(IDP_GROUP, &val, ROOT_PROP); - collection_engine_settings_init(root_reference.scene.collection_properties, true); - } - - if (root_reference.layer_collection == NULL) { - root_reference.layer_collection = IDP_New(IDP_GROUP, &val, ROOT_PROP); - collection_engine_settings_init(root_reference.layer_collection, false); - } - - /* Render engine setting. */ - if (root_reference.scene.render_settings == NULL) { - root_reference.scene.render_settings = IDP_New(IDP_GROUP, &val, ROOT_PROP); - layer_engine_settings_init(root_reference.scene.render_settings, true); - } - - if (root_reference.view_layer == NULL) { - root_reference.view_layer = IDP_New(IDP_GROUP, &val, ROOT_PROP); - layer_engine_settings_init(root_reference.view_layer, false); - } -} - -/** - * Free the reference scene collection settings IDProperty group. - */ -static void layer_collection_engine_settings_validate_free(void) -{ - IDProperty *idprops[] = { - root_reference.scene.render_settings, - root_reference.scene.collection_properties, - root_reference.view_layer, - root_reference.layer_collection, - NULL, - }; - - IDProperty **idprop = &idprops[0]; - while (*idprop) { - if (*idprop) { - IDP_FreeProperty(*idprop); - MEM_freeN(*idprop); - *idprop = NULL; - idprop++; - } - } -} - -/** - * Make sure Scene has all required collection settings. - */ -void BKE_layer_collection_engine_settings_validate_scene(Scene *scene) -{ - if (root_reference.scene.collection_properties == NULL) { - engine_settings_validate_init(); - } - - if (scene->collection_properties == NULL) { - IDPropertyTemplate val = {0}; - scene->collection_properties = IDP_New(IDP_GROUP, &val, ROOT_PROP); - BKE_layer_collection_engine_settings_create(scene->collection_properties); - } - else { - IDP_MergeGroup(scene->collection_properties, root_reference.scene.collection_properties, false); - } -} - -/** - * Make sure Scene has all required collection settings. - */ -void BKE_view_layer_engine_settings_validate_scene(Scene *scene) -{ - if (root_reference.scene.render_settings == NULL) { - engine_settings_validate_init(); - } - - if (scene->layer_properties == NULL) { - IDPropertyTemplate val = {0}; - scene->layer_properties = IDP_New(IDP_GROUP, &val, ROOT_PROP); - BKE_view_layer_engine_settings_create(scene->layer_properties); - } - else { - IDP_MergeGroup(scene->layer_properties, root_reference.scene.render_settings, false); - } -} - /** \} */ /* Iterators */ @@ -2090,44 +1705,15 @@ void BKE_view_layer_bases_in_mode_iterator_end(BLI_Iterator *UNUSED(iter)) /* Evaluation */ -/** - * Reset props - * - * If props_ref is pasted, copy props from it - */ -static void idproperty_reset(IDProperty **props, IDProperty *props_ref) -{ - IDPropertyTemplate val = {0}; - - if (*props) { - IDP_FreeProperty(*props); - MEM_freeN(*props); - } - *props = IDP_New(IDP_GROUP, &val, ROOT_PROP); - - if (props_ref) { - IDP_MergeGroup(*props, props_ref, true); - } -} - -static void layer_eval_layer_collection_pre(Depsgraph *depsgraph, ID *owner_id, ViewLayer *view_layer) +static void layer_eval_layer_collection_pre(Depsgraph *depsgraph, ID *UNUSED(owner_id), ViewLayer *view_layer) { DEG_debug_print_eval(depsgraph, __func__, view_layer->name, view_layer); - Scene *scene = (GS(owner_id->name) == ID_SCE) ? (Scene *)owner_id : NULL; + //Scene *scene = (GS(owner_id->name) == ID_SCE) ? (Scene *)owner_id : NULL; for (Base *base = view_layer->object_bases.first; base != NULL; base = base->next) { base->flag &= ~(BASE_VISIBLED | BASE_SELECTABLED); } - /* Sync properties from scene to scene layer. */ - if (scene) { - idproperty_reset(&view_layer->properties_evaluated, scene->layer_properties); - IDP_MergeGroup(view_layer->properties_evaluated, scene->collection_properties, true); - } - else { - idproperty_reset(&view_layer->properties_evaluated, NULL); - } - /* TODO(sergey): Is it always required? */ view_layer->flag |= VIEW_LAYER_ENGINE_DIRTY; } @@ -2261,11 +1847,3 @@ void BKE_layer_eval_view_layer_indexed(struct Depsgraph *depsgraph, BLI_assert(view_layer != NULL); BKE_layer_eval_view_layer(depsgraph, owner_id, view_layer); } - -/** - * Free any static allocated memory. - */ -void BKE_layer_exit(void) -{ - layer_collection_engine_settings_validate_free(); -} diff --git a/source/blender/blenkernel/intern/scene.c b/source/blender/blenkernel/intern/scene.c index eb2b1bbe26f..950db7d7453 100644 --- a/source/blender/blenkernel/intern/scene.c +++ b/source/blender/blenkernel/intern/scene.c @@ -252,7 +252,6 @@ void BKE_scene_copy_data(Main *bmain, Scene *sce_dst, const Scene *sce_src, cons /* Recursively creates a new SceneCollection tree. */ BKE_collection_copy_data(mc_dst, mc_src, flag_subdata); - IDPropertyTemplate val = {0}; BLI_duplicatelist(&sce_dst->view_layers, &sce_src->view_layers); for (ViewLayer *view_layer_src = sce_src->view_layers.first, *view_layer_dst = sce_dst->view_layers.first; view_layer_src; @@ -261,15 +260,6 @@ void BKE_scene_copy_data(Main *bmain, Scene *sce_dst, const Scene *sce_src, cons BKE_view_layer_copy_data(view_layer_dst, view_layer_src, mc_dst, mc_src, flag_subdata); } - sce_dst->collection_properties = IDP_New(IDP_GROUP, &val, ROOT_PROP); - if (sce_src->collection_properties) { - IDP_MergeGroup_ex(sce_dst->collection_properties, sce_src->collection_properties, true, flag_subdata); - } - sce_dst->layer_properties = IDP_New(IDP_GROUP, &val, ROOT_PROP); - if (sce_src->layer_properties) { - IDP_MergeGroup_ex(sce_dst->layer_properties, sce_src->layer_properties, true, flag_subdata); - } - BLI_duplicatelist(&(sce_dst->markers), &(sce_src->markers)); BLI_duplicatelist(&(sce_dst->transform_spaces), &(sce_src->transform_spaces)); BLI_duplicatelist(&(sce_dst->r.views), &(sce_src->r.views)); @@ -520,19 +510,8 @@ void BKE_scene_free_ex(Scene *sce, const bool do_id_user) MEM_freeN(sce->collection); sce->collection = NULL; - /* LayerCollection engine settings. */ - if (sce->collection_properties) { - IDP_FreeProperty(sce->collection_properties); - MEM_freeN(sce->collection_properties); - sce->collection_properties = NULL; - } - - /* Render engine setting. */ - if (sce->layer_properties) { - IDP_FreeProperty(sce->layer_properties); - MEM_freeN(sce->layer_properties); - sce->layer_properties = NULL; - } + /* These are freed on doversion. */ + BLI_assert(sce->layer_properties == NULL); } void BKE_scene_free(Scene *sce) @@ -813,14 +792,6 @@ void BKE_scene_init(Scene *sce) sce->collection = MEM_callocN(sizeof(SceneCollection), "Master Collection"); BLI_strncpy(sce->collection->name, "Master Collection", sizeof(sce->collection->name)); - /* Engine settings */ - IDPropertyTemplate val = {0}; - sce->collection_properties = IDP_New(IDP_GROUP, &val, ROOT_PROP); - BKE_layer_collection_engine_settings_create(sce->collection_properties); - - sce->layer_properties = IDP_New(IDP_GROUP, &val, ROOT_PROP); - BKE_view_layer_engine_settings_create(sce->layer_properties); - BKE_view_layer_add(sce, "View Layer"); /* SceneDisplay */ |