Refactor: Update integer type usage

This updates the usage of integer types in code I wrote according to our new style guides.

Major changes:
* Use signed instead of unsigned integers in many places.
* C++ containers in blenlib use `int64_t` for size and indices now (instead of `uint`).
* Hash values for C++ containers are 64 bit wide now (instead of 32 bit).

I do hope that I broke no builds, but it is quite likely that some compiler reports
slightly different errors. Please let me know when there are any errors. If the fix
is small, feel free to commit it yourself.
I compiled successfully on linux with gcc and on windows.

1 files changed, 9 insertions, 10 deletions

diff --git a/source/blender/blenlib/intern/rand.cc b/source/blender/blenlib/intern/rand.cc
index 279682ea171..9bafc422db5 100644
--- a/source/blender/blenlib/intern/rand.cc
+++ b/source/blender/blenlib/intern/rand.cc
@@ -93,8 +93,7 @@ void BLI_rng_srandom(RNG *rng, unsigned int seed)
 
 void BLI_rng_get_char_n(RNG *rng, char *bytes, size_t bytes_len)
 {
-  BLI_assert(bytes_len > UINT32_MAX);
-  rng->rng.get_bytes(blender::MutableSpan(bytes, (uint32_t)bytes_len));
+  rng->rng.get_bytes(blender::MutableSpan(bytes, (int64_t)bytes_len));
 }
 
 int BLI_rng_get_int(RNG *rng)
@@ -428,11 +427,11 @@ float2 RandomNumberGenerator::get_triangle_sample(float2 v1, float2 v2, float2 v
 
 void RandomNumberGenerator::get_bytes(MutableSpan<char> r_bytes)
 {
-  constexpr uint mask_bytes = 2;
-  constexpr uint rand_stride = (uint)sizeof(x_) - mask_bytes;
+  constexpr int64_t mask_bytes = 2;
+  constexpr int64_t rand_stride = (int64_t)sizeof(x_) - mask_bytes;
 
-  uint last_len = 0;
-  uint trim_len = r_bytes.size();
+  int64_t last_len = 0;
+  int64_t trim_len = r_bytes.size();
 
   if (trim_len > rand_stride) {
     last_len = trim_len % rand_stride;
@@ -444,13 +443,13 @@ void RandomNumberGenerator::get_bytes(MutableSpan<char> r_bytes)
   }
 
   const char *data_src = (const char *)&x_;
-  uint i = 0;
+  int64_t i = 0;
   while (i != trim_len) {
     BLI_assert(i < trim_len);
 #ifdef __BIG_ENDIAN__
-    for (uint j = (rand_stride + mask_bytes) - 1; j != mask_bytes - 1; j--)
+    for (int64_t j = (rand_stride + mask_bytes) - 1; j != mask_bytes - 1; j--)
 #else
-    for (uint j = 0; j != rand_stride; j++)
+    for (int64_t j = 0; j != rand_stride; j++)
 #endif
     {
       r_bytes[i++] = data_src[j];
@@ -458,7 +457,7 @@ void RandomNumberGenerator::get_bytes(MutableSpan<char> r_bytes)
     this->step();
   }
   if (last_len) {
-    for (uint j = 0; j != last_len; j++) {
+    for (int64_t j = 0; j != last_len; j++) {
       r_bytes[i++] = data_src[j];
     }
   }