diff options
author | Campbell Barton <ideasman42@gmail.com> | 2021-12-16 08:17:28 +0300 |
---|---|---|
committer | Campbell Barton <ideasman42@gmail.com> | 2021-12-16 08:27:35 +0300 |
commit | 8dbd406ea0f495b3d404a7433a32b4781953e55a (patch) | |
tree | c8056b188efa299986b7d936e0b578e9f1f43232 /source/blender/blenlib/intern | |
parent | 15c36170092d26b7d6106924270b6e590627fcb6 (diff) |
WM: various changes to file writing behavior
Saving with only a filename (from Python) wasn't being prevented,
while it would successfully write the file to the working-directory,
path remapping and setting relative paths wouldn't work afterwards
as `Main.filepath` would have no directory component.
Disallow this since it's a corner case which only ever occurs
when path names without any directories are used from Python,
the overhead of expanding the working-directory for all data saving
operations isn't worthwhile.
The following changes have been made:
- bpy.ops.wm.save_mainfile() without a filepath argument
fails & reports and error when the file hasn't been saved.
Previously it would write to "untitled.blend" and set the
`G.main->filepath` to this as well.
- bpy.ops.wm.save_mainfile(filepath="untitled.blend")
fails & reports and error as the filename has no directory component.
- `BLI_path_is_abs_from_cwd` was added to check if the path would
attempt to expand to the CWD.
Diffstat (limited to 'source/blender/blenlib/intern')
-rw-r--r-- | source/blender/blenlib/intern/path_util.c | 30 |
1 files changed, 18 insertions, 12 deletions
diff --git a/source/blender/blenlib/intern/path_util.c b/source/blender/blenlib/intern/path_util.c index c40eed711f5..de71188abfe 100644 --- a/source/blender/blenlib/intern/path_util.c +++ b/source/blender/blenlib/intern/path_util.c @@ -1002,25 +1002,30 @@ bool BLI_path_abs(char *path, const char *basepath) return wasrelative; } -bool BLI_path_abs_from_cwd(char *path, const size_t maxlen) +bool BLI_path_is_abs_from_cwd(const char *path) { -#ifdef DEBUG_STRSIZE - memset(path, 0xff, sizeof(*path) * maxlen); -#endif - bool wasrelative = true; - const int filelen = strlen(path); + bool is_abs = false; + const int path_len_clamp = BLI_strnlen(path, 3); #ifdef WIN32 - if ((filelen >= 3 && BLI_path_is_abs(path)) || BLI_path_is_unc(path)) { - wasrelative = false; + if ((ppath_len_clamp >= 3 && BLI_path_is_abs(path)) || BLI_path_is_unc(path)) { + is_abs = true; } #else - if (filelen >= 2 && path[0] == '/') { - wasrelative = false; + if (path_len_clamp >= 2 && path[0] == '/') { + is_abs = true; } #endif + return is_abs; +} - if (wasrelative) { +bool BLI_path_abs_from_cwd(char *path, const size_t maxlen) +{ +#ifdef DEBUG_STRSIZE + memset(path, 0xff, sizeof(*path) * maxlen); +#endif + + if (!BLI_path_is_abs_from_cwd(path)) { char cwd[FILE_MAX]; /* in case the full path to the blend isn't used */ if (BLI_current_working_dir(cwd, sizeof(cwd))) { @@ -1031,9 +1036,10 @@ bool BLI_path_abs_from_cwd(char *path, const size_t maxlen) else { printf("Could not get the current working directory - $PWD for an unknown reason.\n"); } + return true; } - return wasrelative; + return false; } #ifdef _WIN32 |