Cleanup: Internal degrees removal.

This patch changes most of the reamining degrees usage in internal code into radians.
I let a few which I know off asside, for reasons explained below - and I'm not sure to have found out all of them.

WARNING: this introduces forward incompatibility, which means files saved from this version won't open 100% correctly
         in previous versions (a few angle properties would use radians values as degrees...).

Details:
- Data:
-- Lamp.spotsize: Game engine exposed this setting in degrees, to not break the API here I kept it as such
                  (using getter/setter functions), still using radians internally.
-- Mesh.smoothresh: Didn't touch to this one, as we will hopefully replace it completely by loop normals currently in dev.

- Modifiers:
-- EdgeSplitModifierData.split_angle, BevelModifierData.bevel_angle: Done.

- Postprocessing:
-- WipeVars.angle (sequencer's effect), NodeBokehImage.angle, NodeBoxMask.rotation, NodeEllipseMask.rotation: Done.

- BGE:
-- bConstraintActuator: Orientation type done (the minloc[0] & maxloc[0] cases). Did not touch to 'limit location' type,
                        it can also limit rotation, but it exposes through RNA the same limit_min/limit_max, which hence
                        can be either distance or angle values, depending on the mode. Will leave this to BGE team.
-- bSoundActuator.cone_outer_angle_3d, bSoundActuator.cone_inner_angle_3d: Done (note I kept degrees in BGE itself,
                                                                           as it seems this is the expected value here...).
-- bRadarSensor.angle: Done.

Reviewers: brecht, campbellbarton, sergey, gaiaclary, dfelinto, moguri, jbakker, lukastoenne, howardt

Reviewed By: brecht, campbellbarton, sergey, gaiaclary, moguri, jbakker, lukastoenne, howardt
Thanks to all!

Differential Revision: http://developer.blender.org/D59

1 files changed, 82 insertions, 1 deletions

diff --git a/source/blender/blenloader/intern/versioning_260.c b/source/blender/blenloader/intern/versioning_260.c
index 14eb8ff4ea6..e023e8eed1d 100644
--- a/source/blender/blenloader/intern/versioning_260.c
+++ b/source/blender/blenloader/intern/versioning_260.c
@@ -2530,7 +2530,88 @@ void blo_do_versions_260(FileData *fd, Library *UNUSED(lib), Main *main)
 		}
 	}
 
-	{
+	if (!MAIN_VERSION_ATLEAST(main, 269, 4)) {
+		/* Internal degrees to radians conversions... */
+		{
+			Scene *scene;
+			Object *ob;
+			Lamp *lamp;
+
+			for (lamp = main->lamp.first; lamp; lamp = lamp->id.next)
+				lamp->spotsize = DEG2RADF(lamp->spotsize);
+
+			for (ob = main->object.first; ob; ob = ob->id.next) {
+				ModifierData *md;
+				bSensor *bs;
+				bActuator *ba;
+
+				for (md = ob->modifiers.first; md; md = md->next) {
+					if (md->type == eModifierType_EdgeSplit) {
+						EdgeSplitModifierData *emd = (EdgeSplitModifierData *)md;
+						emd->split_angle = DEG2RADF(emd->split_angle);
+					}
+					else if (md->type == eModifierType_Bevel) {
+						BevelModifierData *bmd = (BevelModifierData *)md;
+						bmd->bevel_angle = DEG2RADF(bmd->bevel_angle);
+					}
+				}
+
+				for (bs = ob->sensors.first; bs; bs = bs->next) {
+					if (bs->type == SENS_RADAR) {
+						bRadarSensor *brs = bs->data;
+						brs->angle = DEG2RADF(brs->angle);
+					}
+				}
+
+				for (ba = ob->actuators.first; ba; ba = ba->next) {
+					if (ba->type == ACT_CONSTRAINT) {
+						bConstraintActuator *bca = ba->data;
+						if (bca->type == ACT_CONST_TYPE_ORI) {
+							bca->minloc[0] = DEG2RADF(bca->minloc[0]);
+							bca->maxloc[0] = DEG2RADF(bca->maxloc[0]);
+						}
+					}
+					else if (ba->type == ACT_SOUND) {
+						bSoundActuator *bsa = ba->data;
+						bsa->sound3D.cone_outer_angle = DEG2RADF(bsa->sound3D.cone_outer_angle);
+						bsa->sound3D.cone_inner_angle = DEG2RADF(bsa->sound3D.cone_inner_angle);
+					}
+				}
+			}
+
+			for (scene = main->scene.first; scene; scene = scene->id.next) {
+				Sequence *seq;
+				SEQ_BEGIN (scene->ed, seq)
+				{
+					if (seq->type == SEQ_TYPE_WIPE) {
+						WipeVars *wv = seq->effectdata;
+						wv->angle = DEG2RADF(wv->angle);
+					}
+				}
+				SEQ_END
+			}
+
+			FOREACH_NODETREE(main, ntree, id) {
+				if (ntree->type == NTREE_COMPOSIT) {
+					bNode *node;
+					for (node = ntree->nodes.first; node; node = node->next) {
+						if (node->type == CMP_NODE_BOKEHIMAGE) {
+							NodeBokehImage *n = node->storage;
+							n->angle = DEG2RADF(n->angle);
+						}
+						if (node->type == CMP_NODE_MASK_BOX) {
+							NodeBoxMask *n = node->storage;
+							n->rotation = DEG2RADF(n->rotation);
+						}
+						if (node->type == CMP_NODE_MASK_ELLIPSE) {
+							NodeEllipseMask *n = node->storage;
+							n->rotation = DEG2RADF(n->rotation);
+						}
+					}
+				}
+			} FOREACH_NODETREE_END
+		}
+
 		if (!DNA_struct_elem_find(fd->filesdna, "MovieTrackingPlaneTrack", "float", "image_opacity")) {
 			MovieClip *clip;
 			for (clip = main->movieclip.first; clip; clip = clip->id.next) {